Ticket #4329 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

RSD-Generated API Links broken when site != url

Reported by: redsweater Assigned to: josephscott
Priority: normal Milestone: 2.2.1
Component: XML-RPC Version: 2.2
Severity: normal Keywords:
Cc: redsweater

Description

A MarsEdit customer discovered a bug with his WordPress installation's RSD content. For WordPress installations where the wordpress directory differs from the blog URL direcdtory, the RSD file generated by WordPress contains xmlrpc.php URLs that point to the wrong place.

The bug is in xmlrpc.php, where URLs for pointing at xmlrpc.php are generated, e.g.:

<api name="Movable Type" blogID="1" preferred="true" apiLink="<?php bloginfo_rss('url') ?>/xmlrpc.php" />

I believe the bloginfo_rss line should actually be looking up "wpurl" instead of "url".

The funny thing is, a nearly identical bug caused the RSD link to not be found in this circumstance, but was fixed:

http://trac.wordpress.org/ticket/2349

Of course, now it finds the RSD - it's just full of useless URLs :)

The customer noticed this on WP 2.2, but I believe it's been around forever. Note in the initial RSD checkin, all the "bloginfo" keys are "url":

http://trac.wordpress.org/changeset/3009

The ticket linked above fixed the problem for the link TO the rsd, but not for the links generated by the RSD.

Attachments

xmlrpc.php-diff (1.2 kB) - added by josephscott on 05/24/07 16:51:50.

Change History

05/24/07 14:38:09 changed by rob1n

I think the xmlrpc.php is supposed to be in the same directory as the index.php.

05/24/07 16:03:07 changed by redsweater

If that's true then the previous fix (2349) was wrong, right?

05/24/07 16:27:43 changed by foolswisdom

  • owner changed from anonymous to josephscott.

Confirmed bug on trunk.

05/24/07 16:51:50 changed by josephscott

  • attachment xmlrpc.php-diff added.

05/24/07 16:54:04 changed by josephscott

My diff adjusts all of the API links to use bloginfo_rss('wpurl') instead of bloginfo_rss('url'). For blogs with where home == siteurl this is effectively a no-op.

05/24/07 17:09:39 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5537]) RSD link fixes from Joseph Scott. fixes #4329 for 2.3

05/24/07 17:10:09 changed by ryan

(In [5538]) RSD link fixes from Joseph Scott. fixes #4329 for 2.2