Ticket #4398 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

Prune options table

Reported by: ryan Assigned to: Nazgul
Priority: normal Milestone: 2.3
Component: Administration Version: 2.3
Severity: normal Keywords: has-patch commit
Cc:

Description

option_can_override, option_type, option_width, option_height, option_description, and option_admin_level are all unused and should be removed from the schema.

Attachments

4398.diff (4.0 kB) - added by Nazgul on 06/12/07 20:24:31.
4398.002.diff (4.6 kB) - added by markjaquith on 06/12/07 22:28:21.

Change History

06/04/07 00:36:39 changed by rob1n

Can we do this without breaking plugins? I remember this came up a while back but people mentioned that plugins used those unused fields for their own values.

06/04/07 03:04:09 changed by ryan

Looking through the plugin repository, I see option_description used here and there. Maybe we can keep that one, although I'd rather just axe it and the others and get plugins to use the API that has been around for years. Doing direct queries circumvents the cache. Anyhow, we're already busting plugins in 2.3 with the taxonomy schema changes. Let's bust some more. :-)

06/04/07 04:08:39 changed by rob1n

+1 then. Survival of the fittest plugin ;).

06/04/07 15:26:58 changed by markjaquith

Axe 'em.

06/12/07 20:24:31 changed by Nazgul

  • attachment 4398.diff added.

06/12/07 20:25:06 changed by Nazgul

  • keywords set to has-patch.
  • owner changed from anonymous to Nazgul.
  • status changed from new to assigned.
  • type changed from defect to enhancement.

06/12/07 22:28:21 changed by markjaquith

  • attachment 4398.002.diff added.

06/12/07 22:29:34 changed by markjaquith

Nazgul, your patch neglected to remove the columns from the schema, so they'd be re-created on the next upgrade! :-) Try 002 on for size.

06/13/07 07:48:33 changed by Nazgul

Mark, thanks for the new patch!

I'd removed them in my source, but for some reason that didn't make it into my patch. Weird.

07/22/07 15:34:16 changed by Nazgul

  • keywords changed from has-patch to has-patch commit.

09/05/07 19:24:00 changed by markjaquith

  • status changed from assigned to closed.
  • version set to 2.3.
  • resolution set to fixed.

(In [6039]) Deprecate option_can_override, option_type, option_width, option_height, option_description, option_admin_level from options table. Props Nazgul. fixes #4398