Ticket #4403 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Tags duplicated when editing comments

Reported by: ryan Assigned to: anonymous
Priority: normal Milestone: 2.2.1
Component: Administration Version: 2.2.1
Severity: normal Keywords:
Cc:

Description

Create a comment with the text "test".

Edit the comment, you will see this in the textarea.

<p>test</p>

Click "Edit Comment" to save the comment. Don't make any changes.

Edit it again. The textarea now has this:

<p><p>test</p></p>

Save and edit a third time and you get:

<p><p></p><p>test</p></p>

Change History

06/04/07 17:34:52 changed by ryan

  • summary changed from autop duplicates tags when editing comments to Tags duplicated when editing comments.

I think this is fallout from #4333. Working on a fix.

06/04/07 17:42:07 changed by ryan

Running the comment_text filter before calling format_to_edit in get_comment_to_edit() fixes it. Calling the comment_text filter when editing a comment is odd. We typically use such filters only when displaying the text on the front page, not when editing. However, we've been running comment_text on comments while editing for awhile now, so I'll leave it.

06/04/07 17:43:22 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5646]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.3

06/04/07 17:46:02 changed by ryan

(In [5647]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.2

06/04/07 17:49:02 changed by ryan

(In [5648]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.0

06/05/07 14:41:02 changed by ryan

(In [5655]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.3

06/05/07 14:41:29 changed by ryan

(In [5656]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.2

06/05/07 14:41:49 changed by ryan

(In [5657]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.0