Integrate Optimal Title

+1

What I'm thinking is basically another argument for wp_title (right now we've got separator and display) which is an argument string that has order and so on.

Also, it would be nice if, on a 404, the text could be Not Found, or something more useful.

Optimal title could be replaced by this code:

function optimal_title_filter($title, $sep) {
	$sections = explode(" $sep ", $title);
	array_push($sections, array_shift($sections));
	$optimal_title = implode(" $sep ", $sections);
	return $optimal_title;
}
add_filter('wp_title','optimal_title_filter',10,2);

This filter would make the normal wp_title() call function in the same way as optimal title 3.0 does. Just add the filter when needed.

@Otto: So are you thinking about including it in the trunk?

@cpoteet: Not my call. I was just offering up code to use if the devs decide to put it in there. :)

Robin - Going to add this.

I decided instead of integration the explode/implode in the plugin to add a parameter as rob1n suggested.

Basically, it adds a parameter onto wp_title that determines the location of the separator. Acceptable values are 'right' or 'left' but defaults to it being on the left as it behaves now. The if/else check only looks at whether the separator is placed on the right and moves it.

What do you think?

Let's just change the default.

Replying to ryan:

Let's just change the default.

So, should we scrap the parameter and just switch the ordering? Let me know Ryan, and I'll make the change.

Yes, scrap the parameter and switch the ordering. It's a better default.

Actually, after looking at how various themes use wp_title(), we probably can't change the default. So, I think we can go with your current patch.

Replying to ryan:

Actually, after looking at how various themes use wp_title(), we probably can't change the default. So, I think we can go with your current patch.

Ya, that's why I figured to keep the default as the legacy position. Maybe in a future release we could switch it indefinitely.

Thanks Ryan!

(In [6538]) Add separator location arg to wp_title. Props cpoteet. fixes #4407

Nice! This will replace the use of plugin optimal title Thanks you so much!