Ticket #4462 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

previous_posts_link() mangles query string

Reported by: markjaquith Assigned to: anonymous
Priority: high Milestone: 2.2.1
Component: Template Version: 2.2
Severity: major Keywords:
Cc:

Description

Using previous_posts_link() from http://example.com/?s=test&paged=2 will give you a link of:

http://example.com/?s=test#038;paged=1

next_posts_link() is not afflicted.

We'll want this in 2.2.1 as well.

Change History

06/14/07 02:16:00 changed by ryan

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems. Anyhow, that's a different issue.

06/14/07 02:21:22 changed by rob1n

  • milestone changed from 2.3 (trunk) to 2.2.1.

06/14/07 02:58:05 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [5702]) remove &paged=1 *before* we HTML entitize the link. fixes #4462

06/14/07 03:01:46 changed by markjaquith

Yeah, my mistake, this only affected 2.2.x

Created #4463 for the bug Ryan noticed.

06/14/07 03:10:46 changed by markjaquith

  • status changed from closed to reopened.
  • resolution deleted.

Still not right... missing the question mark.

06/14/07 03:38:12 changed by markjaquith

  • status changed from reopened to closed.
  • resolution set to fixed.

Bugs are like onions, they have layers. This was fixed after all, it just uncovered another issue.

See #4464

06/14/07 03:38:51 changed by markjaquith

(In [5703]) only strip question marks from the RIGHT side of the query string. fixes #4464. see #4462