Ticket #4465 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

add_query_arg() uses REQUEST_URI when it is undesirable to do so

Reported by: markjaquith Assigned to: anonymous
Priority: normal Milestone: 2.2.1
Component: General Version: 2.2
Severity: normal Keywords:
Cc:

Description

mod_rewrite permalinks, blog URL as domain root.

from http://example.com/page/2/

code: 

echo remove_query_arg('arbitrary', '');

expected result is a blank string (remove a query arg from a blank string, you should get that same blank string back).

actual result: 

/page/2/

It's using the REQUEST URI because it thinks you haven't provided your own query string. But you have... it's just blank. add_query_arg() and remove_query_arg() need to use something other than a blank string to designate that the user has neglected to provide their own QS.

Change History

06/14/07 05:12:22 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [5705]) use FALSE to designate lack of user-supplied URL in *_query_arg() funcs. fixes #4465 for 2.3 (trunk)

06/14/07 05:13:01 changed by markjaquith

(In [5706]) use FALSE to designate lack of user-supplied URL in *_query_arg() funcs. fixes #4465 for 2.2.x