Ticket #4506 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

"Posts Tagged xxx" In Archives In Default Theme Doesn't Show Tag Name

Reported by: Viper007Bond Assigned to: pishmishy
Priority: high Milestone: 2.3
Component: Template Version: 2.3
Severity: normal Keywords: has-patch
Cc:

Description

Click a tag under a post. The tag is missing from the title. 

Posts Tagged ‘’

Simply put, single_cat_title() isn't outputting the tag name.

Attachments

general-template.php.patch (501 bytes) - added by pishmishy on 06/27/07 09:43:05.
Adds single_tag_title function
archive.php.patch (0.8 kB) - added by pishmishy on 06/27/07 09:44:19.
uses new function in default theme
taxonomy.php.patch (439 bytes) - added by pishmishy on 06/27/07 09:45:36.
general-template.php.diff (0.9 kB) - added by gdevlugt on 07/23/07 22:31:47.

Change History

(follow-ups: ↓ 2 ↓ 6 ) 06/27/07 08:41:37 changed by pishmishy

I think the problem is that single_cat_title() is meant to output the tag name.

(in reply to: ↑ 1 ) 06/27/07 09:21:42 changed by pishmishy

Replying to pishmishy:

I think the problem is that single_cat_title() is meant to output the tag name.

Sorry that really wasn't clear. What I meant is that single_cat_title() isn't meant to output the tag name and there probably should be an equivalent single_cat_title().

06/27/07 09:43:05 changed by pishmishy

  • attachment general-template.php.patch added.

Adds single_tag_title function

06/27/07 09:44:19 changed by pishmishy

  • attachment archive.php.patch added.

uses new function in default theme

06/27/07 09:45:36 changed by pishmishy

  • attachment taxonomy.php.patch added.

06/27/07 09:48:04 changed by pishmishy

  • keywords changed from needs-patch to has-patch.

I ran into problems writing the single_tag_title() function. I'm not entirely sure what purpose 

$value = sanitize_title($field);

served in taxonomy.php and it appeared to me to break that particular function when searching based on a slug.

06/28/07 09:28:32 changed by pishmishy

  • owner changed from anonymous to pishmishy.
  • status changed from new to assigned.

07/23/07 22:31:47 changed by gdevlugt

  • attachment general-template.php.diff added.

07/23/07 22:35:49 changed by gdevlugt

I added a patch for the single_cat_title() function in wp-includes/general-template.php.

I haven't tested it fully but it seems to work.

(in reply to: ↑ 1 ) 08/13/07 07:56:16 changed by Viper007Bond

Replying to pishmishy:

I think the problem is that single_cat_title() is meant to output the tag name.

Hmm, guess it'd help if I noticed that 'cat' != 'tag', huh? D'oh.

09/11/07 18:06:53 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6074]) Set tag_id to first tag in multi tag queries. Have single_cat_title() fallback to single_tag_title() if is_tag so that existing category templates will work with tags. fixes #4506