Ticket #4517 (new enhancement)

Opened 11 months ago

Last modified 3 months ago

Bundle Sandbox theme, and also set 'sandbox' as the default template for themes without a stylesheet

Reported by: JeremyVisser Assigned to: anonymous
Priority: low Milestone: 2.6
Component: Template Version:
Severity: minor Keywords: has-patch commit
Cc:

Description

I propose that we bundle the Sandbox theme with WordPress.

Sandbox is a theme which is loaded with semantic CSS selectors, making it possible to write beautiful WordPress themes with only modifying CSS. In addition, it is already widgets-friendly, and is licensed under the GPL, making it perfectly compatible with WordPress in legal terms.

There is a great deal of support for the theme out on the wp-hackers list. Bundling Sandbox has come up a few times, with general support from all directions, but nothing has really happened.

In addition to bundling Sandbox, I propose, for style.css-only themes, that Sandbox is made the default template. (e.g. without having to specify /* Template: sandbox */)

The rationale for this is that Sandbox is much easier to theme with just CSS, and is much more useful than using the Kubrick template, which doesn't contain as many selectors.

Attachments

4517-add-sandbox-theme.diff (236.9 kB) - added by Speedboxer on 06/23/07 22:27:30.
Add Sandbox Theme and Add it to wp-includes/theme.php
4517-add-sandbox-0.9.5-theme.diff (237.2 kB) - added by Speedboxer on 07/10/07 00:51:00.
Add Sandbox 0.9.5 Theme and Add it to wp-includes/theme.php
4517-bundle-sandbox-1.0.diff (220.5 kB) - added by Speedboxer on 11/05/07 06:54:01.
Bundle Sandbox 1.0 and add it to wp-includes/theme.php as a bundled them
4517-bundle-sandbox-1.2.diff (220.6 kB) - added by kalgriffen on 01/06/08 04:03:48.
Include Sandbox 1.2 as a bundled theme and add it to wp-includes/theme.php. Note: the screenshot.png will have to be added manually.

Change History

06/23/07 02:08:23 changed by rob1n

Let's drop Classic then, and replace that with Sandbox.

06/23/07 02:43:44 changed by DD32

Just a thought: Maybe it would be possible to enumerate all the *.css files from a themes folder, parse them, And then display a list of "Other Styles" alongside the theme? ie. themes/classic/ has style.css (default) and my-style.css my-style.css would contain "Theme Name: MY Classic theme", And that'd be offered as a alternate style?

Doing it that way would mean that other styles would have to be coded correctly so as to avoid clashing with eachothers images, But it would allow a single folder for a "Theme".

the other option would be to have a subfolder "Styles" and do it that way with all the themes in the subfolder.

This could be built directly into the theme if some hooks were present for the theme display page.. Perhaps it wouldnt even need hooks and could just be displayed on the Themes Option page.

D

06/23/07 03:51:04 changed by joefish

+1 for adding Sandbox, for all the reasons mentioned in the ticket. This would be a nice addition to WordPress.

-1 for removing Classic. I know I'm in the minority on this, but I think there's room for all three themes.

06/23/07 04:09:56 changed by JeremyVisser

-1 for removing Classic as well. It's a nice theme. Perhaps it could be ported to Sandbox? ;)

-1 on DD32's suggestion as well. It can be done like the following:

File: wp-content/classic-reloaded/style.css

/*
    Theme Name: Classic Reloaded
    Theme Author: Jeremy Visser
    Template: classic
*/

@import url('../classic/style.css');

body {
    background-color: #000;
    color: #f00;
}

}}}

(follow-up: ↓ 6 ) 06/23/07 04:16:39 changed by filosofo

What makes Classic nice is its simplicity for those learning how to create a WordPress theme. Porting it to Sandbox would take away that advantage, as Sandbox (the last time I checked) has some complicated stylesheet switchers that can't be simply removed.

How about dumping the old Default, and instead making the default to be Sandbox's Default lookalike?

(in reply to: ↑ 5 ) 06/23/07 04:34:48 changed by JeremyVisser

Replying to filosofo:

Sandbox (the last time I checked) has some complicated stylesheet switchers that can't be simply removed.

Are you referring to the Skins menu? They dumped that soon after version 0.6. It's not present in 0.9, and I presume the "way to do things" now is to use /* Template: sandbox */ which is really quite simple, as the styles simply show up as new ones under the themes menu.

(follow-ups: ↓ 8 ↓ 9 ) 06/23/07 04:47:44 changed by matt

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

(in reply to: ↑ 7 ) 06/23/07 05:54:50 changed by JeremyVisser

Replying to matt:

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

By that, I presume leaving /* Template: default */ as the default. I can live with that.

(in reply to: ↑ 7 ; follow-up: ↓ 10 ) 06/23/07 07:28:24 changed by foolswisdom

Replying to matt:

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

Please keep it out of wp-content ;-)

(in reply to: ↑ 9 ) 06/23/07 07:33:01 changed by JeremyVisser

Replying to foolswisdom:

Please keep it out of wp-content ;-)

Good idea.

06/23/07 20:20:07 changed by Speedboxer

  • keywords changed from 2nd-opinion dev-feedback to 2nd-opinion dev-feedback has-patch.
  • milestone changed from 2.4 (future) to 2.3 (trunk).

Patch 4517-add-sandbox-theme.diff adds [The Sandbox Theme http://www.plaintxt.org/themes/sandbox/] to WordPress.

I think if this does go into WP, it might as well go into 2.3...

(follow-up: ↓ 13 ) 06/23/07 21:51:19 changed by JeremyVisser

  • keywords changed from 2nd-opinion dev-feedback has-patch to has-patch.

We've had enough feedback to show that it's definitely going in. Thanks, guys.

Matt (Speedboxer), any idea how to get Sandbox into wp-includes?

06/23/07 22:27:30 changed by Speedboxer

  • attachment 4517-add-sandbox-theme.diff added.

Add Sandbox Theme and Add it to wp-includes/theme.php

(in reply to: ↑ 12 ) 06/23/07 22:32:35 changed by Speedboxer

Replying to JeremyVisser:

We've had enough feedback to show that it's definitely going in. Thanks, guys. Matt (Speedboxer), any idea how to get Sandbox into wp-includes?

Updated Patch 4517-add-sandbox-theme.diff Adds Sandbox 0.9.4 and Adds it as a Bundled theme in wp-includes/theme.php.

06/23/07 23:43:49 changed by scottwallick

I was intending to do this myself in the near future, but I'm happier to see it suggested by another. Cheers, Jeremy.

I find /* Template: sandbox */ potentially valuable, especially considering there will (hopefully) be a respectable number of great designs available for the Sandbox after SDC concludes.

(follow-up: ↓ 18 ) 06/26/07 01:55:56 changed by matt

Although I believe Sandbox is the most advanced markup I've seen on a theme, I still don't think it's enough to preclude all template editing. Just like any other theme, I think Sandbox should live in wp-content and we should expect people to edit it just like they do with kubrick or classic.

06/26/07 04:01:36 changed by foolswisdom

I'll keep dreaming of a pure wp-content and custom css / overlay system ;-)

(follow-up: ↓ 20 ) 06/26/07 04:07:28 changed by markjaquith

Well, if people modify the HTML, all those hot CSS themes aren't going to work. So hopefully that will be an incentive for them to leave it alone.

(in reply to: ↑ 15 ; follow-up: ↓ 19 ) 06/27/07 09:44:33 changed by JeremyVisser

Replying to matt:

Although I believe Sandbox is the most advanced markup I've seen on a theme, I still don't think it's enough to preclude all template editing. Just like any other theme, I think Sandbox should live in wp-content and we should expect people to edit it just like they do with kubrick or classic.

...which is partly why I'd like it to be the 'default' template for themes, because, say, you could override footer.php if you wanted to adjust that, but have all the other templates get pulled from Sandbox.

(in reply to: ↑ 18 ) 06/27/07 10:30:00 changed by JeremyVisser

Replying to JeremyVisser:

...which is partly why I'd like it to be the 'default' template for themes, because, say, you could override footer.php if you wanted to adjust that, but have all the other templates get pulled from Sandbox.

Oops, actually, I think it would work anyway. Disregard.

(in reply to: ↑ 17 ) 06/27/07 10:40:22 changed by matt

Replying to markjaquith:

Well, if people modify the HTML, all those hot CSS themes aren't going to work. So hopefully that will be an incentive for them to leave it alone.

When I look at common modifications around doing things like Adsense, changing hardcoded text or formatting, words for comments, all of the "content" things that CSS isn't designed to touch, it rarely has an impact on the layout. In theory we could make all of the above configurable, but I think we'd be on the wrong end of 80/20 for the benefits.

07/09/07 13:39:41 changed by sunburntkamel

if we can get this committed, it would be great. sandbox still needs support for 2.3 features (tags), and doing that in trac here means that standalone sandbox can still support 2.0 without a lot of conditional statements.

07/09/07 13:47:55 changed by JeremyVisser

  • keywords changed from has-patch to has-patch commit.

There has definitely been plenty of positive feedback on this. Looks like it's time to commit. Thanks, Matt (Speedboxer), for the patch!

(follow-up: ↓ 25 ) 07/09/07 13:49:09 changed by JeremyVisser

Sandbox 0.9.5 is out. Matt, could you cook us up another patch for the new version? Your current one is for 0.9.4.

07/10/07 00:51:00 changed by Speedboxer

  • attachment 4517-add-sandbox-0.9.5-theme.diff added.

Add Sandbox 0.9.5 Theme and Add it to wp-includes/theme.php

07/10/07 00:54:48 changed by Speedboxer

Patch 4517-add-sandbox-0.9.5-theme.diff adds Sandbox 0.9.5 and adds it as a packaged theme in wp-includes/theme.php.

(in reply to: ↑ 23 ) 07/10/07 00:57:14 changed by Speedboxer

Replying to JeremyVisser:

Sandbox 0.9.5 is out. Matt, could you cook us up another patch for the new version? Your current one is for 0.9.4.

No problem, I didn't notice a new version was out. Check out Patch 4517-add-sandbox-0.9.5-theme.diff. :D

08/22/07 22:16:53 changed by rob1n

  • milestone changed from 2.3 (trunk) to 2.4 (future).

11/05/07 06:54:01 changed by Speedboxer

  • attachment 4517-bundle-sandbox-1.0.diff added.

Bundle Sandbox 1.0 and add it to wp-includes/theme.php as a bundled them

11/05/07 06:56:23 changed by Speedboxer

Patch 4517-bundle-sandbox-1.0.diff adds Sandbox 1.0 as a bundled theme. It's added in wp-includes/theme.php also.

01/06/08 04:03:48 changed by kalgriffen

  • attachment 4517-bundle-sandbox-1.2.diff added.

Include Sandbox 1.2 as a bundled theme and add it to wp-includes/theme.php. Note: the screenshot.png will have to be added manually.

02/27/08 22:10:19 changed by ryan

  • milestone changed from 2.5 to 2.6.