Ticket #4522 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Template: default broken

Reported by: sunburntkamel Assigned to: anonymous
Priority: normal Milestone: 2.2.2
Component: Template Version: 2.2.1
Severity: normal Keywords: has-patch theme template linebreaks
Cc: scottwallick, dougal

Description

in 2.2.1, and all versions of newer than r5630, using template: to create stylesheet based themes is broken (i.e. http://codex.wordpress.org/Theme_Development#Theme_Style_Sheet )

every server configuration i've tried (WAMP, LAMP, PHP 5), others reporting the same problem.

diff that caused the issue: http://trac.wordpress.org/changeset?old_path=trunk%2Fwp-includes%2Ftheme.php&old=5630&new_path=trunk%2Fwp-includes%2Ftheme.php&new=5747

Attachments

theme.php.diff (339 bytes) - added by dougal on 06/27/07 19:05:20.
patch against 2.2.1 wp-includes/theme.php

Change History

06/24/07 03:38:18 changed by scottwallick

It seems that there were line breaks introduced in themes.php post-r5620 that caused this problem.

Also breaks in my configs as well, but r5630 works fine.

06/27/07 19:05:20 changed by dougal

  • attachment theme.php.diff added.

patch against 2.2.1 wp-includes/theme.php

06/27/07 19:06:19 changed by dougal

  • cc changed from scottwallick to scottwallick, dougal.
  • keywords changed from theme template linebreaks to has-patch theme template linebreaks.

Yup, definitely broken in 2.2.1. There is no handling of the $template variable (which is to say, it remains an array as returned from the preg_match when parsing the template metadata). Patch attached.

06/27/07 22:45:53 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [5770]) Fix stylesheet-based themes. props dougal. fixes #4522