Ticket #4654 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

permalink_single_rss needs a filter

Reported by: joostdevalk Assigned to: westi
Priority: normal Milestone: 2.3
Component: Administration Version: 2.3
Severity: normal Keywords: has-patch commit
Cc:

Description

summary says it all, you can't filter the output of permalink_single_rss

Attachments

patch.txt (372 bytes) - added by joostdevalk on 07/19/07 19:02:54.
Patch
4654.diff (17.1 kB) - added by Otto42 on 07/24/07 13:51:58.
Deprecate permalink_single_rss, replace with the_permalink_rss. Also adds the_permalink_rss filter.

Change History

07/19/07 18:38:37 changed by joostdevalk

  • owner changed from anonymous to joostdevalk.
  • status changed from new to assigned.

07/19/07 18:39:00 changed by joostdevalk

  • owner deleted.
  • status changed from assigned to new.

07/19/07 18:39:57 changed by joostdevalk

  • keywords set to has-patch.

07/19/07 19:02:54 changed by joostdevalk

  • attachment patch.txt added.

Patch

07/19/07 20:35:35 changed by Otto42

+1 to adding a filter specifically for the rss permalink output.

But why is it called permalink_single_rss() anyway? Wouldn't the_permalink_rss() make more sense? Suggest renaming this function and all the calls to it.

07/19/07 20:43:54 changed by westi

  • owner set to westi.
  • status changed from new to assigned.

Adding the filter is obviously a no brainer as for renaming - it is a published template tag so we would need to retain the old version in deprecated.php for a while.

I'm not sure the rename is worth it.

What does everyone else think?

07/19/07 23:50:25 changed by Nazgul

I'm +1 for renaming, for consistnecies sake. We use the the_xxx format almost everywhere, so we should do it here as well.

07/24/07 07:49:43 changed by rob1n

That patch can be made a lot simpler, too, into one line.

07/24/07 13:51:58 changed by Otto42

  • attachment 4654.diff added.

Deprecate permalink_single_rss, replace with the_permalink_rss. Also adds the_permalink_rss filter.

07/24/07 13:56:59 changed by Otto42

Added my patch suggestion. Sorry for the excessive whitespace changes in the patch, there's a lot of whitespace at the end of lines that my editor removes whenever I edit a PHP file.

08/03/07 15:48:43 changed by joostdevalk

What else needs done before this can get committed?

08/09/07 03:59:45 changed by JeremyVisser

  • keywords changed from has-patch to has-patch commit.

Wait for it. We sometimes use the 'commit' keyword, but I'm not sure if the developers use that or not.

08/10/07 08:17:53 changed by markjaquith

Otto42, could you deactivate that whitespace cleanup feature of your text editor before creating patches? I'm a big fan of cleanup, but when it's mixed in with functional changes, it makes it really hard to see what has changed. I'd rather have condensed functional diffs and then separate whitespace cleanup diffs.

And yes, I know I've been guilty of this too in the past. :-)

08/21/07 18:27:46 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5910]) Deprecate permalink_single_rss(). Add the_permalink_rss() with accompanying filter. Props joostdevalk and Otto42. fixes #4654