Ticket #4686 (closed defect: duplicate)

Opened 1 year ago

Last modified 9 months ago

WXR need a version

Reported by: foolswisdom Assigned to: tellyworth
Priority: high Milestone:
Component: Administration Version: 2.3
Severity: major Keywords: export, import, WXR, needs-patch
Cc:

Description (Last modified by foolswisdom)

WXR need a version

ENV: wp trunk r5819

Quite a few of the WXR bugs relate to older versions of WP not being able to handle newer versions of WP exports.

If WXR included a version # then if the version # of the file was greater than the version that WP knows how to handle then WP could give a warning, and save users some headaches.

ADDITIONAL DETAILS:
The svn revision when it last changed might work as good as anything else.

Change History

07/30/07 21:54:08 changed by foolswisdom

  • description changed.

07/30/07 23:44:52 changed by markjaquith

Need it for 2.2.2 as well, as it uses CDATA for comment_author now.

(follow-up: ↓ 4 ) 07/31/07 07:15:30 changed by westi

+1 This is a very good idea.

Some thoughts:

  1. Tie the WXR version down and only change features in full releases not maintenance releases - this means things like the CDATA change in 2.2.2 should not get done as 2.2 should support import and export of it's version of WXR and any earlier versions.
  2. Write up a good spec for the format which highlights the new features in different versions.

(in reply to: ↑ 3 ) 07/31/07 16:41:21 changed by foolswisdom

Seems like a good idea to rollback the importer part of #4452.

westi's bang on comments remind me, that the importer version check should actually be a range bounded on each side, b/c the upgrade process already needs to be robust. Bester for a user to be encouraged to upgrade the origin install than for the importer code to become spaghetti -- though when reasonable the importer should be backwards compat.

07/31/07 16:42:04 changed by foolswisdom

  • keywords changed from export, import, WXR, to export, import, WXR, needs-patch.

rollback on 2.2.x *

08/01/07 16:12:29 changed by markjaquith

Lloyd, don't you mean roll back the exporter ? If we roll back the importer, WP 2.2.2 won't be able to import its exports. The importer changes should be backwards compat, but the exporter changes are not.

08/01/07 16:22:14 changed by foolswisdom

Grr, yes, what you said, roll back the exporter not the importer for 2.2.x .

08/03/07 14:51:23 changed by markjaquith

(In [5846]) Roll back export portion of #4452 for 2.2.x, see #4452, see #4686

08/03/07 14:53:11 changed by markjaquith

Still need to decide on a versioning system and implement it for trunk.

09/05/07 22:40:52 changed by ryan

  • milestone changed from 2.3 to 2.4 (next).

09/21/07 15:52:28 changed by link92

Why on earth does this require versioning? The output of the XML parser should be identical with or without a CDATA section around the commenter name…

Versioning just gives us an excuse to breaks backwards compatibility in a format that most certainly should not ever need backwards compatibility broken.

09/21/07 17:44:04 changed by foolswisdom

link92, please don't comment if you aren't going to be polite, why on Earth indeed.

Versioning: * Helps detection of backwards compatibility issues * Makes handling backwards compatibility easier, more graceful * Allows an experience wwarning when someone trying to import from a forward version

12/12/07 05:44:24 changed by lloydbudd

  • status changed from new to closed.
  • resolution set to duplicate.

Duplicate of #5454.

12/12/07 12:06:02 changed by westi

Hmm #5454 gives it a version number but does it have a spec that says what that means yet?

01/24/08 17:10:17 changed by Nazgul

  • milestone deleted.