Ticket #4704 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Invalid RSS2 Comments Feed

Reported by: lexhair Assigned to: anonymous
Priority: high Milestone: 2.2.3
Component: Administration Version: 2.2.1
Severity: normal Keywords: has-patch
Cc:

Description

Version 2.2.2. My comments RSS2 feed was invalid because the author tags did not enclose a valid email address.

I modified the feed-rss2-comments.php file to include xlmns:dc="http://purl.org/dc/elements/1.1/" in the head space and changed the author tags to dc:creator tags. This validated the comments feed.

I apologize for not submitting the patch as a diff but I'm quite a noob when it comes to this stuff.

Attachments

rss2comments-patch.zip (1.3 kB) - added by lexhair on 08/08/07 18:11:54.
Patched feed-rss2-comments.php file for feed validation
4704-222.diff (1.0 kB) - added by Otto42 on 08/08/07 19:30:26.
dc:creator patch for 2.2.2
4704-trunk.diff (1.0 kB) - added by Otto42 on 08/08/07 19:30:40.
dc:creator patch for trunk

Change History

08/06/07 18:30:37 changed by Otto42

  • keywords set to has-patch.
  • priority changed from normal to high.
  • version set to 2.2.1.
  • milestone set to 2.3 (trunk).

Agreed, this causes all comment feeds to be invalid. The author element is supposed to conform to RFC822.

http://cyber.law.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt http://feedvalidator.org/docs/error/InvalidContact.html

I'm attaching a patch to fix this for 2.2.2. Trunk patch coming soon.

08/06/07 18:34:06 changed by Otto42

Ahh.. It just occurred to me that it might not be desirable to publish email addresses of comment authors, considering it says that you won't on the default theme page. So... forget the above patch, perhaps the dc:creator would indeed be a better way to go.

08/07/07 09:25:09 changed by Viper007Bond

Yeah, publishing e-mails = major eww and should be avoided at all costs.

08/08/07 18:11:16 changed by lexhair

I'll attach my patched feed-rss2-comments.php so if someone wants to make a diff out of it, go for it.

08/08/07 18:11:54 changed by lexhair

  • attachment rss2comments-patch.zip added.

Patched feed-rss2-comments.php file for feed validation

08/08/07 19:30:26 changed by Otto42

  • attachment 4704-222.diff added.

dc:creator patch for 2.2.2

08/08/07 19:30:40 changed by Otto42

  • attachment 4704-trunk.diff added.

dc:creator patch for trunk

08/08/07 19:31:25 changed by Otto42

Added dc:creator based patches for 2.2.2 and trunk. These change the author to dc:creator, which eliminates the validation issue.

08/16/07 18:34:58 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5881]) Use dc:creator instead of author for rss2 comment feeds. Props lexhair, Otto42. fixes #4704 for 2.3

08/16/07 18:35:11 changed by ryan

(In [5882]) Use dc:creator instead of author for rss2 comment feeds. Props lexhair, Otto42. fixes #4704 for 2.2

08/16/07 18:35:37 changed by ryan

  • milestone changed from 2.3 (trunk) to 2.2.3.