Ticket #4741 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Multiple $wp_query objects mess a lot of things up

Reported by: mdawaffe Assigned to: anonymous
Priority: normal Milestone: 2.3
Component: Administration Version: 2.2.2
Severity: normal Keywords:
Cc:

Description

Many themes call query_posts() one or more times, each overwriting the previous $wp_query object. Unless we're super careful, this can break a lot of stuff. To get back to the original query, I find myself doing

$GLOBALS['wp_query'] = $GLOBALS['wp_the_query'];

a lot.

I propose a new wp_reset_query() function that replaces $wp_query with the original $wp_the_query. It might prove useful to attach that function to the wp_footer action. It'd probably actually fix a lot of custom stuff out there that no one knew was broken, but it'd likely also break a few things for people.

Attached adds the function and no more.

Attachments

4741.diff (399 bytes) - added by mdawaffe on 08/13/07 18:34:42.

Change History

08/13/07 18:34:42 changed by mdawaffe

  • attachment 4741.diff added.

08/13/07 21:02:01 changed by westi

+1

This sounds like a really useful function.

08/14/07 04:11:44 changed by markjaquith

+1

08/20/07 22:55:43 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [5907]) wp_reset_query() from mdawaffe. fixes #4741