Ticket #4742 (closed defect: fixed)

Opened 1 year ago

Last modified 10 months ago

phpdoc for taxonomy API

Reported by: ryan Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.3
Severity: normal Keywords: taxonomy phpdoc has-patch developer-feedback
Cc: josephscott

Description

The new taxonomy API needs phpdoc. A few of the functions in wp-includes/taxonomy.php have the beginnings of some phpdoc, but they need to be updated and extended.

Attachments

taxonomy.phpdoc.diff (7.4 kB) - added by darkdragon on 08/15/07 05:30:47.
taxonomy.phpdoc.r5900.diff (16.7 kB) - added by darkdragon on 08/19/07 19:23:21.
Completed more phpDoc for functions. Fixed some previous descriptions, and added blank descriptions with params and return completed to other functions.
taxonomy.6159.phpdoc.patch (17.5 kB) - added by darkdragon on 09/23/07 04:40:39.
More phpDoc for revision 6159, still incomplete.
taxonomy.6277.phpdoc.patch (28.1 kB) - added by darkdragon on 10/20/07 05:10:10.
Added @since tags to all functions, cleaned up and correct documentation, as well as added some documentation to functions. Still Incomplete.
taxonomy.r6291.phpdoc.patch (12.1 kB) - added by darkdragon on 10/26/07 05:11:01.
Patched against r6291 and cleans up and brings the total needing documentation to four
taxonomy.6372.phpdoc.diff (17.8 kB) - added by darkdragon on 12/11/07 07:58:21.
Finishes documentation for the Taxonomy API, based off of r6372

Change History

08/13/07 19:03:20 changed by markjaquith

Know of any good phpdoc how-to's ? It may be that a little education is what we need to accelerate phpdoc rollout.

08/13/07 20:33:58 changed by nbachiyski

08/15/07 04:50:38 changed by josephscott

  • cc set to josephscott.

08/15/07 05:30:47 changed by darkdragon

  • attachment taxonomy.phpdoc.diff added.

08/17/07 21:22:38 changed by ryan

(In [5896]) First cut of taxonomy API phpdoc from darkdragon. see #4742

08/19/07 19:23:21 changed by darkdragon

  • attachment taxonomy.phpdoc.r5900.diff added.

Completed more phpDoc for functions. Fixed some previous descriptions, and added blank descriptions with params and return completed to other functions.

08/19/07 19:39:43 changed by darkdragon

Holy crap, you'll find that some functions that short and long descriptions in between others which don't. If the function was easy enough to decipher, I went ahead and filled out the information.

I figure it is easier to complete the param and return information first and then go back when the information is more clear.

Note: I place some extra non-phpdoc tags for some of the filters. Given that non-phpDoc tags won't show up and that the rest of the information is in a @internal tag, I would assume that it won't adversely affect the output. It would allow for a custom plugin or solution to take the tag (if written in PHP5 (be easier at least) ) and output all of the filter and actions information without having to do a search for add_action of add_filter functions. Just thought it might be useful.

09/06/07 22:13:07 changed by Nazgul

  • keywords changed from taxonomy phpdoc to taxonomy phpdoc developer-feedback.

Part of this ticket was commited. Do we commit the rest for 2.3 as well or close this one and open a new ticket for 2.4?

09/12/07 02:56:44 changed by ryan

(In [6092]) More phpdoc for taxonomy from darkdragon. see #4742

09/12/07 02:58:18 changed by ryan

I applied the the second patch. Since I took so long, some parts didn't apply due to conflicts. We can keep working on phpdoc for taxonomy for 2.3 up through the RC on Sep. 17th if anyone is interested.

09/13/07 02:34:23 changed by darkdragon

Well, I do things mostly in stages. Once I realized just how many functions there were and how difficult some of the functions will be to describe I switched over to documenting the parameters, return values, and template the short description and long descriptions for later.

I think at some point, the original developer should go over what I wrote and confirm or correct what I wrote.

09/23/07 04:40:39 changed by darkdragon

  • attachment taxonomy.6159.phpdoc.patch added.

More phpDoc for revision 6159, still incomplete.

09/23/07 04:42:47 changed by darkdragon

Added a patch that almost completely covers the parameters and return values. Missing mostly cache functions.

This patch still doesn't completely cover the short and long descriptions for most of the functions. If anyone wants to help out with that, be my guess. I figure that at least the parameters and return types might be useful at this point of time.

09/23/07 15:34:02 changed by foolswisdom

  • milestone changed from 2.3 to 2.4.

10/15/07 22:49:31 changed by ryan

(In [6254]) More taxonomy phpdoc from darkdragon. see #4742

10/20/07 05:10:10 changed by darkdragon

  • attachment taxonomy.6277.phpdoc.patch added.

Added @since tags to all functions, cleaned up and correct documentation, as well as added some documentation to functions. Still Incomplete.

10/20/07 05:13:56 changed by darkdragon

Goodness, Well on the way to getting there. It always happens that I document this file whenever I'm just about ready to go to bed. I hope the documentation doesn't suffer because of it.

More this weekend I suspect.

10/21/07 17:18:25 changed by ryan

(In [6282]) taxonomy phpdoc updates from darkdragon. see #4742

10/26/07 05:11:01 changed by darkdragon

  • attachment taxonomy.r6291.phpdoc.patch added.

Patched against r6291 and cleans up and brings the total needing documentation to four

10/26/07 05:13:50 changed by darkdragon

Dude! Only four more functions to go! Also three of them are going to be quite time consuming. Can't wait to call this file done!

Patch fixes several errors, @see should not be used in descriptions and must be on its own line.

10/26/07 15:22:16 changed by foolswisdom

Dude! Sweet!

12/11/07 07:58:21 changed by darkdragon

  • attachment taxonomy.6372.phpdoc.diff added.

Finishes documentation for the Taxonomy API, based off of r6372

12/11/07 07:59:51 changed by darkdragon

  • keywords changed from taxonomy phpdoc developer-feedback to taxonomy phpdoc has-patch developer-feedback.

Patch completely documents all of the Taxonomy API.

12/14/07 00:25:40 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6378]) Taxonomy phpdoc from darkdragon. fixes #4742