Ticket #4773 (closed defect: fixed)

Opened 11 months ago

Last modified 9 months ago

Canonical URL addition causes redirection problems

Reported by: jbctech Assigned to: markjaquith
Priority: high Milestone: 2.3
Component: General Version: 2.3
Severity: critical Keywords:
Cc:

Description

The addition of the canonical redirection in changeset 5890 and 5891 in SVN causes my site to display the following error message in Firefox:

The page isn't redirecting properly Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

In Safari, it displays: Safari can’t open the page. Too many redirects occurred trying to open “http://www.MySite.com/”. This might occur if you open a page that is redirected to open another page which then is redirected to open the original page.

I am able to access /wp-admin, and tried changing themes and/or settings with no success. Once I revert back to 5889, it works fine.

Attachments

canonical.php.diff (0.6 kB) - added by jbctech on 09/12/07 05:31:54.
Possible solution

Change History

08/19/07 08:38:36 changed by DD32

Can you perhaps give some more information? Are you using Apache? IIS?(What rewrite modules?) What permalink structure? (Are you using any non-default Mod Rewrite options?)

I've not looked too closely at the code(Yet) but thats just general questions(But we need more info to track down the actual exact problem).

D

08/19/07 17:51:03 changed by jbctech

D,

Sorry - here's a bit more information:

Apache 1.3.37 (Unix)

I believe it's all standard rewrite options - the permalink Structure is "Date and name based" and the only other plugin that modifies the .htaccess file is FAlbum.

08/22/07 19:36:05 changed by Mark

I get this too.

Here is the information I see in the access log if it helps:

- - [22/Aug/2007:14:08:06 -0400] "GET /wp-admin/upgrade.php HTTP/1.1" 200 821 "-" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070224 BonEcho/?2.0.0.2"

- - [22/Aug/2007:14:08:06 -0400] "GET /wp-admin/css/install.css?version=2.3-alpha HTTP/1.1" 200 613 "http://xxx.net/wp-admin/upgrade.php" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070224 BonEcho/?2.0.0.2"

- - [22/Aug/2007:14:08:07 -0400] "GET /wp-admin/images/wordpress-logo.png HTTP/1.1" 200 2345 "http://xxx.net/wp-admin/upgrade.php" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070224 BonEcho/?2.0.0.2"

- - [22/Aug/2007:14:08:08 -0400] "GET /wp-admin/upgrade.php?step=1&backto= HTTP/1.1" 200 751 "http://xxx.net/wp-admin/upgrade.php" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070224 BonEcho/?2.0.0.2"

- - [22/Aug/2007:14:08:10 -0400] "GET / HTTP/1.1" 301 5 "http://xxx.net/wp-admin/upgrade.php?step=1&backto=" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2) Gecko/20070224 BonEcho/?2.0.0.2"

and from there it stays at 301

The only cure was the first permalink option. Anything else causes the browser loop.

At revision 5916.

Tested in Camino too.

08/23/07 03:01:08 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.

I'll need the URL of the blog. The best way to diagnose problems here is using the LiveHTTPHeaders Firefox add-on.

Mark, for your problem I'll disable the canonical functionality in /wp-admin/

08/23/07 03:40:52 changed by markjaquith

(In [5921]) No canonical-ness for wp-admin. see #4773

08/24/07 08:16:10 changed by Mark

http://kirbymuxloe.net

/wp-admin is fine, no problem.

The actual blog gets the message.

Contact me if you want backend access to the blog or ssh

08/24/07 16:47:00 changed by ryan

Post preview links are redirected.

From: http://foo.bar/?p=1501&preview=true To: http://foo.bar/?p=1501?p=1501

08/28/07 08:43:41 changed by Mark

The problem continues either with is_admin() or without that in canonical.php

I guess I'm the only one though so all I can do is revert to 2.2

Tried with the beta-1

I didn't mention there are no plugins and post preview does work albeit as Ryan describes.

08/28/07 19:45:21 changed by ryan

Breaks category paging too.

08/29/07 00:27:26 changed by Nazgul

I'm able to reproduce this.

On my blog, if I surf to http://localhost/blogsvn/, at the end of the redirect_canonical function 'http://localhost/blogsvn/'==$redirect_url and 'http://localhost/blogsvn/index.php'==$requested_url, thus forcing a redirect and going into an infinite loop.

For some reason, the $requested_url gets a bonus index.php from somewhere that's causing this issue.

08/29/07 07:06:22 changed by rejon

  • severity changed from major to critical.

Yes, I get the same thing on overlap.org which is running the latest from SVN. The paging is broken on categories.

08/29/07 15:11:40 changed by westi

See also #4862 possibly related

08/29/07 18:10:12 changed by markjaquith

(In [5974]) Fix paging and preview links for canonical stuff. see #4773. fixes #4862

(follow-up: ↓ 15 ) 08/29/07 21:06:51 changed by markjaquith

(In [5978]) More cautious canonical-ness. Exclude IIS and POSTs. Better paging handling. Still a work in progress! see #4773

(in reply to: ↑ 14 ) 09/03/07 03:33:17 changed by jbctech

Replying to markjaquith:

(In [5978]) More cautious canonical-ness. Exclude IIS and POSTs. Better paging handling. Still a work in progress! see #4773

Is there a way to disable this 'canonical-ness'? I'm still having this problem with the latest svn...

09/03/07 04:15:43 changed by ryan

For now, you can comment out the last line in wp-includes/canonical.php. Of course, we'd appreciate it if you could try new versions as we release them so we can get it fixed for good. :-)

09/10/07 02:27:43 changed by matt

Yes please don't disable without helping us identify the problem first, or it'll be broken for thousands of other people after the release.

09/10/07 13:34:12 changed by wantmoore

  • cc set to wantmoore@gmail.com.

I believe this may also be causing me some trouble on a site I've been developing recently. Site works fine until I enable the Front page/Posts page on the Options->Reading in the admin.

Info: WP Trunk r6065 PHP 4.4.4 MySQL 4.1.22 Apache 1.3.37

Current rewriting being handled by WP via index.php - no .htaccess.

09/10/07 13:34:58 changed by wantmoore

  • cc deleted.

(follow-ups: ↓ 21 ↓ 24 ) 09/10/07 15:08:20 changed by markjaquith

wantmore,

What are your symptoms?

Also, see if this fixed it: [6068] -- it's not related to Canonical URLs, but it is related to PATHINFO URLs and "show page on front page"

(in reply to: ↑ 20 ) 09/10/07 17:10:23 changed by wantmoore

Replying to markjaquith:

wantmore, What are your symptoms? Also, see if this fixed it: [6068] -- it's not related to Canonical URLs, but it is related to PATHINFO URLs and "show page on front page"

I just updated to r6070 and am still having the infinite redirect problem. With Firefox I get: 

The page isn't redirecting properly

      Firefox has detected that the server is redirecting the request for this address in a way that will never complete.
    *   This problem can sometimes be caused by disabling or refusing to accept
          cookies.

It works exactly as expected when I comment out the add_action line in wp-includes/canonical.php

(follow-up: ↓ 23 ) 09/10/07 18:09:45 changed by markjaquith

Where is your site?

(in reply to: ↑ 22 ) 09/10/07 18:30:03 changed by wantmoore

The development site is at http://mindstormweb.com/kellyhastings

(in reply to: ↑ 20 ) 09/11/07 18:41:28 changed by wantmoore

I've svn up'd this morning and am still having the issue.

09/11/07 21:20:39 changed by markjaquith

wantmoore,

Thanks so much for the report. I was able to reproduce the issue, and develop a fix.

09/11/07 21:21:40 changed by markjaquith

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6085]) Always trailingslash the "home" URL. Protect against chained redirects. Thanks wantmoore. fixes #4773

09/12/07 01:25:46 changed by jbctech

  • status changed from closed to reopened.
  • resolution deleted.

This is still broken at revision 6089

09/12/07 05:31:54 changed by jbctech

  • attachment canonical.php.diff added.

Possible solution

09/12/07 05:34:46 changed by jbctech

I found the problem. For my site, the Blog Address (URL) in WordPress Options was http://www.MySite.com, however the canonical redirection was redirecting to http://www.mysite.com. The routine that protects against chained redirects did not handle the difference in case.

I have included the diff of what I did to get mine working... you may want to do it here, or you may want to just force it lower in the options menu.

09/12/07 20:44:42 changed by markjaquith

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6097]) Ignore HOST capitalization differences for canonical redirects. props jbctech. fixes #4773

10/15/07 10:18:02 changed by Funbug

  • status changed from closed to reopened.
  • resolution deleted.

Post preview will redirect infinitely on two of my blogs until I add 

|| is_preview()

at line 7 of canonical.php

10/15/07 10:59:18 changed by Viper007Bond

You should probably make a new ticket for this rather than reopening this one.

10/15/07 11:20:22 changed by Funbug

  • status changed from reopened to closed.
  • resolution set to fixed.

Okay, sorry. I just wasn't sure -> http://trac.wordpress.org/ticket/5203