Ticket #4935 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Pagination is broken

Reported by: matt Assigned to: anonymous
Priority: normal Milestone: 2.3
Component: General Version: 2.3
Severity: blocker Keywords: has-patch
Cc:

Description

The links on (for example) the edit-comments.php are like:

edit-comments.php?apage=%25%23%25

The arguments to paginate_links were getting encoded by add_query_arg.

Attachments

pagination.diff (408 bytes) - added by matt on 09/08/07 02:59:17.
This fixes it.

Change History

09/08/07 02:59:17 changed by matt

  • attachment pagination.diff added.

This fixes it.

09/08/07 02:59:56 changed by matt

  • keywords set to has-patch.

Patch attached, but not sure if that's the best fix.

09/08/07 13:31:03 changed by markjaquith

I think we should probably just forget about http_build_query and use our compat function (which can have the urlencoding turned off). I'll give that a shot.

09/08/07 14:27:25 changed by markjaquith

  • status changed from new to closed.
  • resolution set to fixed.

(In [6064]) Only urlencode previously existing values in add_query_arg() (more backwards compatible). fixes #4935. see #4084. see #4878

09/08/07 17:26:13 changed by mdawaffe

  • status changed from closed to reopened.
  • resolution deleted.

$lsb and friends are never actually used in this patch. Intentional, or should line 123 change?

09/10/07 15:34:14 changed by markjaquith

(In [6069]) Forgot to use $lsb and $rsb in [6064]. Props mdawaffe. see #4935. see #4878

09/10/07 15:34:58 changed by markjaquith

  • status changed from reopened to closed.
  • resolution set to fixed.

Thanks. Had that in there at one point. Must have gotten greedy with Cmd-Z after going down a few dead end paths. ;-)

09/10/07 15:53:34 changed by markjaquith

(In [6070]) Actually, we always need to URLencode square brackets... or wp_redirect() will strip them out. see #4935. see #4878