Ticket #5181 (closed enhancement: fixed)

Opened 9 months ago

Last modified 8 months ago

Refactoring Atom support; baby step #1

Reported by: rubys Assigned to: westi
Priority: normal Milestone: 2.5
Component: General Version:
Severity: normal Keywords: has-patch has-docs
Cc: josephscott, rubys

Description

Overall goal is to converge to a single place each where atom entries are created and consumed. This is a first step.

Move prep_content from wp-app to feed.php; use by both wp-app and feed-atom.

Attachments

prep_content.2.patch (5.2 kB) - added by rubys on 10/17/07 17:43:02.
s/prep_content/prep_atom_text_construct/
prep_content.patch (5.8 kB) - added by rubys on 10/18/07 21:10:04.
now, with phpdocs!

Change History

10/13/07 18:36:43 changed by josephscott

  • cc set to josephscott.

10/13/07 19:55:24 changed by rubys

Joseph Scott suggested that I should mention that this fix passes both APE and the Feed Validator when applied against revision 6220. Revisions 6221-6243 don't pass APE (with or without this fix), due to bug 5180. Revisions 6228-HEAD don't pass Feed Validation (with or without this fix), due to bug 5194.

10/14/07 01:19:19 changed by ryan

With prep_content no longer in the AtomServer? namespace, does it need a more specific function name. prep_content() seems a bit generic. Other than that, looks good to me. If you have a suggestion for a new function name, I can make the change and commit. However, I'm fine with prep_content() if that's what you want.

10/17/07 17:43:02 changed by rubys

  • attachment prep_content.2.patch added.

s/prep_content/prep_atom_text_construct/

10/17/07 19:30:24 changed by westi

  • keywords set to has-patch needs-docs.

Looks good.

Can we have some phpdoc for prep_atom_text_construct please.

10/18/07 21:10:04 changed by rubys

  • attachment prep_content.patch added.

now, with phpdocs!

10/18/07 21:10:22 changed by rubys

  • cc changed from josephscott to josephscott, rubys.

I *knew* there was a reason why I wanted to do this with baby steps. :-)

This is my first time writing phpdoc. If I get something minor wrong, please feel free to correct it. If I get something major wrong, simply toss it back and point me in the right direction.

10/19/07 07:24:06 changed by westi

  • keywords changed from has-patch needs-docs to has-patch has-docs.
  • owner changed from anonymous to westi.
  • status changed from new to assigned.

+1 phpdoc enabled patch looks good

10/19/07 15:42:31 changed by westi

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6273]) Refactor atom support to share code. Fixes #5181 props rubys

11/06/07 18:31:56 changed by foolswisdom

(In [6315]) Back out some of changeset [5273] from #5181. Props rubys. fixes #5307