Ticket #5494 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Improperly formed tag field inputs can create blank tags

Reported by: ionfish Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: General Version: 2.5
Severity: normal Keywords: has-patch commit
Cc:

Description

Similar to #5412, if you put in a string with a bunch of commas into the tag field you can create blank tags. This is the string I used:

testtest2,test3

Which generated several blank tags in addition to 'test', 'test2' and 'test3'.

Attachments

validate_terms.patch (429 bytes) - added by ionfish on 12/19/07 22:40:35.
Drop blank terms before saving, per jhodgdon on IRC.

Change History

12/19/07 21:57:58 changed by ionfish

Looks like Trac ate my commas. 

test,,test2,,,test3

12/19/07 22:40:35 changed by ionfish

  • attachment validate_terms.patch added.

Drop blank terms before saving, per jhodgdon on IRC.

12/19/07 23:18:06 changed by JeremyVisser

  • keywords changed from needs-patch to has-patch.

12/19/07 23:22:07 changed by JeremyVisser

  • keywords changed from has-patch to has-patch commit.

Patch confirmed to fix bug.

12/19/07 23:22:24 changed by JeremyVisser

  • milestone changed from 2.5 to 2.4.

12/19/07 23:25:12 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6424]) Don't create blank terms. Props ionfish and jhodgdon. fixes #5494