Ticket #5508 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

names displayed 2 or 3 times when you edit user's profile

Reported by: jopa Assigned to: anonymous
Priority: low Milestone: 2.5
Component: Administration Version: 2.3.1
Severity: normal Keywords: 2nd-opinion has-patch
Cc:

Description

Hello everyone,

I am new here and i've just installed wordpress and i am really happy with the features and its simplicity.

After spending some hours searching and touching things here and there - trying to create my personal blog - i found that when you go to edit a user's profile, in the field: "Display name publicly as: " it shows in the list the username 2 times. If you dont touch the Nickname field then it shows 3 times the same username.

Its not something critical and probably it doesnt create any problem for wordpress in general, however i've just noticed that and thought that it could be a good idea to inform you about it.

Sorry if that bug has been mentioned before but i checked your system and i didnt find anything.

See the screenshots for more details.

Problem checked with both firefox and opera browsers.

Thanks

Attachments

wordpress2.jpg (130.9 kB) - added by jopa on 12/22/07 23:10:40.
wordpress1.jpg (131.3 kB) - added by jopa on 12/22/07 23:11:50.
unique-display-name-suggestions.diff (2.0 kB) - added by nbachiyski on 01/24/08 19:33:20.

Change History

12/22/07 23:10:40 changed by jopa

  • attachment wordpress2.jpg added.

12/22/07 23:11:50 changed by jopa

  • attachment wordpress1.jpg added.

12/27/07 11:13:58 changed by jopa

  • type changed from task to defect.
  • milestone changed from 2.5 to 2.3.2.

12/27/07 11:28:23 changed by DD32

  • keywords set to 2nd-opinion needs-patch.
  • milestone changed from 2.3.2 to 2.5.

The reason for multiple versions being shown would be the Username/Real Name/Nickname entered being identical. I'm not too sure why when the Real name is empty it displays the username though.. So it might be something else there.

A Possibility would be to only show unique values, However, With the current form, If you change the details that the display name relied upon, I believe it'll change that too...

Milestone to 2.5 as it doesnt have a patch.

(follow-up: ↓ 4 ) 12/30/07 10:33:31 changed by jopa

Maybe it feels the "empty" fields with the username and because of that it makes it to be displayed 2 and 3 times?

(in reply to: ↑ 3 ) 12/30/07 10:35:29 changed by jopa

i mean fills* not feels sorry.

01/02/08 14:16:01 changed by jopa

just to inform you that this problem exists in the new version of wordpress too.

I've just installed wordpress v2.3.2 and i've checked it and again the names are displayed 2 or 3 times.

Thanks

01/03/08 05:32:52 changed by darkdragon

  • status changed from new to closed.
  • resolution set to invalid.
  • milestone deleted.

This is expected behavior since WordPress uses the user's username for each of the three fields. It is likely to inform the user, albeit counter-intuitive to some users.

Thinking about it, if you checked to see if username, nickname, and display name are the same and only display one, then a new user might not conceive that if they changed any of those that the values in the drop down will also change.

It might seem like a bug, but it was helpful to me and I'm sure it is helpful to others to realize the true intent of the drop down.

See wp_insert_user() for more details.

01/24/08 04:33:19 changed by nbachiyski

  • keywords changed from 2nd-opinion needs-patch to 2nd-opinion has-patch.
  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to 2.5.

darkdragon, it may be helpful for you, because you just see how the things work under the hood and see the point. However, for most of the users it is just irritating.

Here is a patch from me.

01/24/08 04:56:53 changed by darkdragon

Fine by me, my point was that unless there is a patch, there is no point arguing over something that is by all means intentional.

By the way, you forgot one. There is also: lastname, space, firstname.

Patch looks awesome.

01/24/08 19:33:20 changed by nbachiyski

  • attachment unique-display-name-suggestions.diff added.

01/24/08 19:35:40 changed by nbachiyski

  • priority changed from normal to low.

Updated the patch with the missing combination, thanks.

01/24/08 23:39:18 changed by ryan

The same needs to be done for profile.php. We should see if user-edit.php and profile.php can be combined. Maybe they can share an edit-user-form.php template.

01/25/08 01:33:29 changed by ryan

(In [6652]) Eliminate dupes from display name list. Props nbachiyski. see #5508

01/25/08 01:34:02 changed by ryan

Committed the user-edit.php patch. Leaving open for profile.php.

01/29/08 17:01:37 changed by jopa

Hmm..

darkdragon maybe for some advanced users is usefull, but unfortunately for newbie users like me that seems strange.. and make us believe that wordpress is not working properly.

Glad to see that this ticket is reopened.. Wordpress is a great blog software and it would be nice everything to work perfectly..

Thanks nbachiyski for the patch.

I second ryan's comment about combining the user-edit.php and profile.php

01/30/08 22:15:25 changed by nbachiyski

  • status changed from reopened to closed.
  • resolution set to fixed.

The merge has its own ticket -- #5736, so I will close this one.