Ticket #5591 (assigned enhancement)

Opened 11 months ago

Last modified 3 months ago

Use jQuery for Custom Image Header

Reported by: ryan Assigned to: rmccue (accepted)
Priority: normal Milestone: 2.9
Component: Administration Version:
Severity: normal Keywords: jquery has-patch needs-testing
Cc:

Description

As part of our conversion to jQuery, let's convert wp-admin/custom-header.php to jQuery plus something like farbtastic for the colorpicker. I'm not sure what to use for the cropper. Interface has some crop code, but interface isn't actively maintained these days. It might still be useful for the crop code, however.

http://acko.net/dev/farbtastic

Attachments

farbtastic.diff (50.1 kB) - added by rmccue on 08/28/08 10:24:48.
Convert custom-header.php to jQuery
farbtastic.2.diff (20.4 kB) - added by rmccue on 08/28/08 10:39:09.
Leave colorpicker.js in for backwards compat.
marker.png (0.6 kB) - added by rmccue on 08/28/08 10:45:21.
marker.png from Farbtastic, goes in wp-admin/css/
mask.png (2.0 kB) - added by rmccue on 08/28/08 10:45:55.
mask.png from Farbtastic, goes in wp-admin/css/
wheel.png (11.5 kB) - added by rmccue on 08/28/08 10:50:34.
wheel.png from Farbtastic, goes in wp-admin/css/
farbtastic.3.diff (20.5 kB) - added by rmccue on 08/28/08 11:22:19.
Default now works properly

Change History

01/07/08 02:43:48 changed by tellyworth

There's a jQuery color picker plugin:

http://plugins.jquery.com/project/color-picker

Also an image cropper here:

http://interface.eyecon.ro/demos/resize.html

It's based on Interface Elements for jQuery.

Can't vouch for either other than a quick test (they look ok in Safari).

01/08/08 06:00:20 changed by rmccue

  • owner changed from anonymous to rmccue.

Mine! All mine! I'm integrating Farbtastic at the moment. However, there's no suitable alternative for Cropper, so we're going to leave that for the moment. The interface plugin mentioned above leaves artifacts when dragging.

08/25/08 10:41:26 changed by Viper007Bond

  • keywords changed from jquery to jquery needs-patch.
  • type changed from defect to enhancement.
  • component changed from General to Administration.

+1 for Farbtastic. It's f'ing awesome (using it in one of my upcoming plugins).

08/28/08 10:24:48 changed by rmccue

  • attachment farbtastic.diff added.

Convert custom-header.php to jQuery

08/28/08 10:27:57 changed by rmccue

  • keywords changed from jquery needs-patch to jquery has-patch needs-testing.
  • status changed from new to assigned.

Added patch to convert everything to jQuery except the cropper. Farbtastic is now also included (images in wp-admin/images/, farbtastic.css in wp-admin/css/ and farbtastic.js in wp-admin/js/) as a replacement for colorpicker.

08/28/08 10:39:09 changed by rmccue

  • attachment farbtastic.2.diff added.

Leave colorpicker.js in for backwards compat.

08/28/08 10:45:21 changed by rmccue

  • attachment marker.png added.

marker.png from Farbtastic, goes in wp-admin/css/

08/28/08 10:45:55 changed by rmccue

  • attachment mask.png added.

mask.png from Farbtastic, goes in wp-admin/css/

08/28/08 10:50:34 changed by rmccue

  • attachment wheel.png added.

wheel.png from Farbtastic, goes in wp-admin/css/

08/28/08 10:52:25 changed by rmccue

Sorry, all those images go in wp-admin/images/ instead.

08/28/08 11:22:19 changed by rmccue

  • attachment farbtastic.3.diff added.

Default now works properly

08/28/08 17:42:22 changed by ryan

(In [8760]) Use farbtastic for custom header color picker. Props rmmccue. see #5591