Ticket #5600 (closed task: fixed)

Opened 9 months ago

Last modified 9 months ago

ReadMe Version Bump To 2.5

Reported by: fitztrev Assigned to: spencerp
Priority: lowest Milestone: 2.5
Component: General Version: 2.5
Severity: normal Keywords: has-patch tested commit
Cc:

Description

The current readme.html file has the WordPress version hardcoded in. I thought the purpose of wp-includes/version.php was so that we'd only have the version stored in one location.

Attachments

readme.diff (387 bytes) - added by fitztrev on 01/07/08 15:17:19.
readmehtml.diff (0.8 kB) - added by spencerp on 01/14/08 00:58:20.

Change History

01/07/08 15:17:19 changed by fitztrev

  • attachment readme.diff added.

01/09/08 09:34:14 changed by spencerp

  • owner changed from anonymous to spencerp.

Just added an up-to-date version of the readme file from latest trunk revision.

(follow-up: ↓ 5 ) 01/09/08 09:40:29 changed by JeremyVisser

It's not possible to have this grabbed from wp-includes/version.php, because it's a static PHP file that cannot run PHP. This is because the file is designed to be viewed by WordPress users who download the zip/tarball, then look at the readme.html file by double-clicking it in their file browser. Users will likely not read this file as served by a web server -- rather, from a file:// URL, which means no PHP.

That's why it's hardcoded.

01/09/08 10:31:28 changed by spencerp

  • priority changed from normal to lowest.

01/09/08 10:32:06 changed by spencerp

  • type changed from enhancement to task.

(in reply to: ↑ 2 ) 01/09/08 22:05:16 changed by fitztrev

That's why it's hardcoded.

I realize that it can't be changed to grab the version variable value from wp-includes/version.php, but I don't think that the version number is even necessary in the README, anyway. It creates an extra burden for the developers to bump the version here, too. Also, I don't think it's that important to have in their for the readers in the first place. My patch removes it altogether.

01/10/08 07:51:12 changed by spencerp

  • summary changed from ReadMe cleanup to ReadMe Version Bump To 2.5.

01/12/08 04:39:03 changed by thee17

  • keywords set to has-patch tested-working.
  • version set to 2.5.

01/12/08 05:08:50 changed by darkdragon

  • keywords changed from has-patch tested-working to has-patch tested commit.

01/14/08 00:58:20 changed by spencerp

  • attachment readmehtml.diff added.

01/14/08 04:39:36 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6608]) Bump ver in readme. Props fitzrev and spencerp. fixes #5600