Ticket #5607 (closed defect: fixed)

Opened 8 months ago

Last modified 1 month ago

Fix PHP Notices in admin

Reported by: filosofo Assigned to: westi
Priority: normal Milestone: 2.6
Component: General Version: 2.5
Severity: normal Keywords:
Cc: filosofo

Description

Ah, the joys of having WP_DEBUG set to "true."

Attachments

remove_admin_notices.diff (2.1 kB) - added by filosofo on 01/08/08 21:18:43.
remove_admin_notices2.diff (1.6 kB) - added by filosofo on 01/08/08 21:20:00.
remove_admin_notices3.diff (2.2 kB) - added by filosofo on 01/08/08 21:21:19.
remove_admin_notices4.diff (1.4 kB) - added by filosofo on 01/08/08 21:22:00.
remove_admin_notices5.diff (4.2 kB) - added by filosofo on 01/08/08 21:22:49.
remove_admin_notices6.diff (2.4 kB) - added by filosofo on 01/08/08 21:23:37.
remove_admin_notices7.diff (4.0 kB) - added by filosofo on 01/08/08 21:24:16.
remove_admin_notices8.diff (2.0 kB) - added by filosofo on 01/08/08 21:26:15.
remove_admin_notices9.diff (2.6 kB) - added by filosofo on 01/08/08 21:26:51.
remove_admin_notices10.diff (1.8 kB) - added by filosofo on 01/08/08 21:27:35.
remove_admin_notices11.diff (4.7 kB) - added by filosofo on 01/08/08 21:28:17.
remove_admin_notices12.diff (5.8 kB) - added by filosofo on 01/08/08 21:29:15.
remove_admin_notices13.diff (2.2 kB) - added by filosofo on 01/08/08 21:30:03.
remove_admin_notices14.diff (3.8 kB) - added by filosofo on 01/08/08 21:30:37.
remove_admin_notices15.diff (1.7 kB) - added by filosofo on 01/08/08 21:31:23.
remaining_notices.diff (29.8 kB) - added by westi on 01/10/08 20:53:49.
Merged patch for wp-admin remaining notices

Change History

01/08/08 21:18:43 changed by filosofo

  • attachment remove_admin_notices.diff added.

01/08/08 21:19:23 changed by westi

  • owner changed from anonymous to westi.
  • status changed from new to assigned.

Thank you for the patch!

From a quick look through I am not sure that 100% of the changes are the best fix.

I will go through and review and commit soon.

01/08/08 21:20:00 changed by filosofo

  • attachment remove_admin_notices2.diff added.

01/08/08 21:21:19 changed by filosofo

  • attachment remove_admin_notices3.diff added.

01/08/08 21:22:00 changed by filosofo

  • attachment remove_admin_notices4.diff added.

01/08/08 21:22:49 changed by filosofo

  • attachment remove_admin_notices5.diff added.

01/08/08 21:23:37 changed by filosofo

  • attachment remove_admin_notices6.diff added.

01/08/08 21:24:16 changed by filosofo

  • attachment remove_admin_notices7.diff added.

01/08/08 21:26:15 changed by filosofo

  • attachment remove_admin_notices8.diff added.

01/08/08 21:26:51 changed by filosofo

  • attachment remove_admin_notices9.diff added.

01/08/08 21:27:35 changed by filosofo

  • attachment remove_admin_notices10.diff added.

01/08/08 21:28:17 changed by filosofo

  • attachment remove_admin_notices11.diff added.

01/08/08 21:29:15 changed by filosofo

  • attachment remove_admin_notices12.diff added.

01/08/08 21:30:03 changed by filosofo

  • attachment remove_admin_notices13.diff added.

01/08/08 21:30:37 changed by filosofo

  • attachment remove_admin_notices14.diff added.

01/08/08 21:31:23 changed by filosofo

  • attachment remove_admin_notices15.diff added.

01/08/08 21:32:41 changed by filosofo

Sorry for so many patches, but I couldn't get a clean diff with a large patch.

What are some examples of problems with the changes?

01/10/08 20:51:07 changed by westi

(In [6592]) Notice fixing for wp-includes. See #5607 props filosofo.

01/10/08 20:53:49 changed by westi

  • attachment remaining_notices.diff added.

Merged patch for wp-admin remaining notices

01/10/08 20:54:43 changed by westi

Ok wp-includes changes reviewed and some modifications made.

Patch for just the wp-admin changes uploaded - will review when I have some more time.

07/17/08 03:47:14 changed by jacobsantos

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from 2.9 to 2.6.1.

I think there should only be one ticket for notices and warnings fixes per WordPress version. Closing as fixed. A new ticket should be created for 2.7, 2.8, etc.

07/17/08 03:47:19 changed by jacobsantos

  • keywords deleted.

07/28/08 23:47:01 changed by ryan

  • milestone changed from 2.6.1 to 2.6.