Ticket #5611 (closed enhancement: fixed)

Opened 6 months ago

Last modified 5 months ago

PHPdoc effort for phpdoc fixes in 2.5

Reported by: darkdragon Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: Optimization Version:
Severity: normal Keywords: phpdoc
Cc:

Description

For any mistakes with the phpdoc, patches will be here for WordPress 2.5.

Attachments

phpdocfixes.phpdoc.r6582.diff (9.6 kB) - added by darkdragon on 01/09/08 14:12:49.
First round of phpdoc fixes based off of r6582

Change History

01/09/08 14:12:49 changed by darkdragon

  • attachment phpdocfixes.phpdoc.r6582.diff added.

First round of phpdoc fixes based off of r6582

01/09/08 14:14:53 changed by darkdragon

Patch also includes file level documentation for rss.php.

01/09/08 14:17:43 changed by darkdragon

When patch is committed, it should be the last external library file that needs file level documentation.

Patch also "fixes" @since information that has 2.4 as the version and moves it to 2.5. The reason for this even though it was added during the 2.4 development was that the since information is for actual releases and the 2.4 was a guess as to which (trunk) version that would be. The current trunk version is 2.5, so all 2.4 @since tags should be 2.5 instead.

01/09/08 17:48:00 changed by ryan

(In [6585]) phpdoc tuneup from darkdragon. see #5611

01/10/08 06:09:41 changed by sambauers

[6585] contains a change to code:

wp-settings.php - line @39 

- unset( $wp_filter, $wp_action, $cache_lastcommentmodified, $cache_lastpostdate );
+ unset( $wp_filter, $cache_lastcommentmodified, $cache_lastpostdate );

Is that a problem?

01/10/08 13:38:47 changed by darkdragon

No. Once upon a time {{{$wp_action} was added to split filters and actions. When actions once again became part of filters, the variable was left over from that.

$wp_actions is however being used.

01/10/08 13:41:07 changed by darkdragon

Actually, I "fixed" that a few months ago and when I made the patch forgot that I had fixed it.

I try to keep surprises to a minimum since it could affect whether or not the patch is committed.

01/11/08 18:38:57 changed by westi

  • keywords changed from phpdoc has-patch commit to phpdoc.

02/17/08 17:27:46 changed by darkdragon

  • status changed from new to closed.
  • resolution set to fixed.

Reopen if someone has more phpdoc fixes for 2.5. Create new ticket for 2.6.

Fixed in [6585].