Ticket #5638 (closed enhancement: fixed)

Opened 11 months ago

Last modified 3 months ago

PHPdoc effort for formatting.php

Reported by: darkdragon Assigned to: westi
Priority: low Milestone: 2.7
Component: Optimization Version:
Severity: trivial Keywords: phpdoc has-patch
Cc:

Description

PHPdoc effort seeks to complete phpdoc style inline documentation for wp-includes/formatting.php.

Needed to complete:

  1. Short and Long Descriptions.
  2. @since version info
  3. parameter type and description.
  4. return type and description.

Attachments

formatting.phpdoc.r6597.diff (28.8 kB) - added by darkdragon on 01/11/08 03:14:51.
Incomplete documentation for formatting.php based off of r6597
5638.r8665.diff (18.9 kB) - added by santosj on 08/18/08 21:29:39.
Formatting.php phpdoc fixes based off of r8665
phpdoc.formatting.diff (33.3 kB) - added by scohoust on 08/20/08 14:27:59.
Expanded phpdoc for formatting.php
5638.r8780.diff (20.0 kB) - added by jacobsantos on 08/30/08 19:07:39.
Corrected inline documentation (@since tags and formatting) based off of r8780
5638.r8781.diff (21.7 kB) - added by jacobsantos on 08/30/08 21:17:27.
Just inline documentation and code styling based from r8781
5638.r8783.diff (6.1 kB) - added by jacobsantos on 08/30/08 22:19:54.
Completes formatting.php based off of r5638.

Change History

01/11/08 03:14:51 changed by darkdragon

  • attachment formatting.phpdoc.r6597.diff added.

Incomplete documentation for formatting.php based off of r6597

01/11/08 03:16:37 changed by darkdragon

Looking to complete in the Summer. If anyone wants to take ownership of the file/ticket, the the patch has all of the template phpdoc style comments in order to do so.

Just apply patch to checked out revision [6597], apply patch, and then update. Finally, fill in blanks and missing information.

(follow-up: ↓ 6 ) 08/14/08 18:16:57 changed by scohoust

I've expanded a bit on what was above. I probably won't be able to spend quite so much time on this so I've added it here in case it's any use.

08/14/08 20:42:42 changed by jacobsantos

Dude, awesome. The patch will have a better chance of being committed if you remove the inline documentation of the functions which don't have any short or long descriptions. However, there are other files with those messages, so it probably won't matter.

Also, formatting.php isn't the Main WordPress API, it is the WordPress Formatting API or Main WordPress Formatting API. functions.php is the main WordPress API.

08/14/08 21:50:45 changed by scohoust

Quickly updated that line, must've just took it from functions.php without changing, thanks for pointing it out.

08/17/08 11:29:44 changed by westi

(In [8662]) phpdoc for formatting functions. See #5638 props scohoust.

(in reply to: ↑ 2 ) 08/17/08 14:35:02 changed by jacobsantos

Replying to scohoust:

I've expanded a bit on what was above. I probably won't be able to spend quite so much time on this so I've added it here in case it's any use.

That is okay man, I'll take over and complete some more functions. I'm going to correct post.php first before I jump over to formatting.php, so if you or anyone else wants to finish the file or finish some more functions that'll be sweet also.

08/17/08 18:21:10 changed by scohoust

I might do a bit more this week, perhaps some of the more obvious functions, and will add anything I complete here. Thanks for committing!

08/18/08 21:29:39 changed by santosj

  • attachment 5638.r8665.diff added.

Formatting.php phpdoc fixes based off of r8665

08/18/08 21:30:57 changed by santosj

Patch corrects some of the phpdoc, removes ending whitespace, and adds periods.

08/20/08 14:27:59 changed by scohoust

  • attachment phpdoc.formatting.diff added.

Expanded phpdoc for formatting.php

08/20/08 14:30:23 changed by scohoust

Patch includes the above patch from jacobsantos plus further documentation.

08/27/08 06:49:22 changed by westi

(In [8743]) phpDoc updates for formatting functions. See #5638 props scohoust and santosj.

08/27/08 18:40:37 changed by santosj

@schoust

The convention has changed to where the short description doesn't have the "function_name() - " text. The reason for the change was that it doesn't make sense in PHPXref and PHPdocumentor sites as well as some editors. The reason I didn't remove all of them was I have had many conflicts in the past with the file and it helps to know which function the inline documentation goes to when conflicts do occur.

I advise that you remove them when you are finished with the inline documentation for a function to keep track of the ones that still need inline documentation. I'm submitting patches that removes them from other files.

08/27/08 18:41:40 changed by santosj

Oh yeah, my patch at home has some updated descriptions and short descriptions that I'm going to make a patch for. I think some short descriptions can be improved for clarity and there are some spelling mistakes.

08/28/08 18:15:55 changed by scohoust

I think I changed the "function_name() -" format from all the functions I documented. There should only be a few functions left undocumented and these are unlikely to be ones I can't explain too well.

I'm sure there are a few bits of mine that could be better written, thanks for reading it over!

08/30/08 19:07:39 changed by jacobsantos

  • attachment 5638.r8780.diff added.

Corrected inline documentation (@since tags and formatting) based off of r8780

(follow-up: ↓ 15 ) 08/30/08 20:00:36 changed by westi

  • keywords changed from phpdoc has-patch to phpdoc has-patch reporter-feedback.
  • owner changed from anonymous to westi.
  • status changed from new to assigned.

Documentation updates look good.

Could we split the bug fixes out into a seperate ticket and just have a patch for the documentation here.

08/30/08 21:17:27 changed by jacobsantos

  • attachment 5638.r8781.diff added.

Just inline documentation and code styling based from r8781

(in reply to: ↑ 14 ) 08/30/08 21:20:19 changed by jacobsantos

  • keywords changed from phpdoc has-patch reporter-feedback to phpdoc has-patch.

Replying to westi:

Documentation updates look good. Could we split the bug fixes out into a seperate ticket and just have a patch for the documentation here.


Done.

08/30/08 21:28:11 changed by westi

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8783]) phpDoc updates for formatting functions fixes #5638 props jacobsantos.

08/30/08 22:18:21 changed by jacobsantos

  • status changed from closed to reopened.
  • resolution deleted.

Upcoming patch completes file.

08/30/08 22:19:54 changed by jacobsantos

  • attachment 5638.r8783.diff added.

Completes formatting.php based off of r5638.

08/31/08 20:58:20 changed by westi

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8786]) phpDoc updates for formatting functions fixes #5638 props jacobsantos.