Ticket #5650 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

get_lastcommentmodified() query optimization

Reported by: ryan Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: General Version: 2.3.2
Severity: normal Keywords: has-patch dev-reviewed
Cc:

Description

get_lastcommentmodified() selects on comment_date_gmt <= $now. comment_data_gmt is not indexed, making this a slow query. I don't see any reason for doing <= $now. Comments can be edited to be in the future; however, future comments are not excluded from any other query. They show in the comments loop.

Attachments

get_lastcommentmodified.diff (2.2 kB) - added by ryan on 01/12/08 17:49:29.

Change History

01/12/08 17:49:29 changed by ryan

  • attachment get_lastcommentmodified.diff added.

01/12/08 18:18:43 changed by westi

  • keywords set to has-patch dev-reviewed.

+1

01/14/08 05:59:40 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6610]) Eliminate comment_date_gmt <= now from get_lastcommentmodified() queries. fixes #5650