Ticket #5694 (closed enhancement: fixed)

Opened 10 months ago

Last modified 10 months ago

Flexible comment counter bubble

Reported by: sambauers Assigned to: matt
Priority: normal Milestone: 2.5
Component: Administration Version:
Severity: normal Keywords:
Cc:

Description

Flexible and re-sizable comment counter bubble.

No limits on comment count need be imposed anymore.

Only tested in Safari and Firefox on Mac.

Rounded corners only available where -khtml-border-radius or border-radius are supported (-moz-border-radius looks terrible) if you want rounded corners via background images we'll need some more images and otherwise redundant markup.

Attachments

comment-bubble.diff (2.5 kB) - added by sambauers on 01/20/08 07:51:12.
comment-stalk.gif (0.5 kB) - added by sambauers on 01/20/08 07:51:44.
comment-pill-left.gif (82 bytes) - added by sunburntkamel on 01/20/08 14:13:41.
left side, flexible background
comment-pill-right.gif (61 bytes) - added by sunburntkamel on 01/20/08 14:14:01.
right side
awaiting-mod.diff (4.2 kB) - added by sunburntkamel on 01/20/08 19:35:08.
diff to menu.php, menu-headers.php, wp-admin.css
comment-buuble-count-fix.diff (1.6 kB) - added by nbachiyski on 01/23/08 15:03:43.

Change History

01/20/08 07:51:12 changed by sambauers

  • attachment comment-bubble.diff added.

01/20/08 07:51:44 changed by sambauers

  • attachment comment-stalk.gif added.

01/20/08 08:09:15 changed by Speedboxer

In IE7, when you do anything that affects the comment count, the "bubble" just has the cornor image and says "NaN".

(follow-up: ↓ 3 ) 01/20/08 14:11:08 changed by sunburntkamel

IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera.

Rather than adding markup, i've added classes to the LI's

01/20/08 14:13:41 changed by sunburntkamel

  • attachment comment-pill-left.gif added.

left side, flexible background

01/20/08 14:14:01 changed by sunburntkamel

  • attachment comment-pill-right.gif added.

right side

01/20/08 19:35:08 changed by sunburntkamel

  • attachment awaiting-mod.diff added.

diff to menu.php, menu-headers.php, wp-admin.css

(in reply to: ↑ 2 ) 01/20/08 21:51:42 changed by Speedboxer

Replying to sunburntkamel:

IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera. Rather than adding markup, i've added classes to the LI's

awaiting-mod.diff is even worse in IE7, half of it gets cut off, including the number. Even worse in IE6 (although, the whole Admin is fairly broken in IE6, too).

It get's screwed up when you zoom in in FF2, also.

01/21/08 22:13:07 changed by matt

  • status changed from new to closed.
  • resolution set to fixed.

(In [6638]) Try a different comment bubble, fixes #5694. Hat tip: sambauers.

01/23/08 15:03:22 changed by nbachiyski

  • status changed from closed to reopened.
  • resolution deleted.

Since the fix added an internal span to the bubble the html of .comment-count wasn't the comment count, but the span, which caused {{{Nan}}s in the bubble.

The patch uses .comment-count span as a selector and adds an internal span to the submenu count in parens, so that both can be updated using the same code.

01/23/08 15:03:43 changed by nbachiyski

  • attachment comment-buuble-count-fix.diff added.

01/29/08 16:43:21 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6678]) Comment bubble count fix from nbachiyski. fixes #5694