Ticket #5721 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

Future posts published with Windows Live Writer are scheduled for incorrect time.

Reported by: markjaquith Assigned to: markjaquith
Priority: normal Milestone: 2.5
Component: XML-RPC Version: 2.3.2
Severity: normal Keywords: has-patch
Cc: josephscott

Description

WP GMT Offset: -05

  1. Compose post in Windows Live Writer
  2. Set publish time to 1 hour in the future
  3. Publish
  4. View "Manage > Posts" and verify that publish time is correct (it is).
  5. View "Dashboard" and note that pseudo cron has the post scheduled to "fire" in 6 hours.

Tried with a few other times, and it seems to be [Publish Time] - [GMT Offset].

Tried on WordPress.com and the post failed to publish (can't see the scheduled time on the dashboard).

I couldn't trigger this bug with MarsEdit (which uses a different API). I'm leaning towards this being a WLW bug, but it's strange that the publish time would be right but the cron time wouldn't.

This is also another reason why our pseudo cron implementation needs a re-work... you shouldn't be able to schedule a post to publish at any time other than its publish date!

Attachments

date_created_gmt__TRUNK.diff (1.9 kB) - added by markjaquith on 01/25/08 19:43:35.
For Trunk

Change History

01/25/08 18:02:39 changed by lloydbudd

  • owner changed from anonymous to josephscott.

01/25/08 18:21:10 changed by lloydbudd

  • owner changed from josephscott to markjaquith.

Mark and Joseph discussed this on IRC #wordpress-hackers -- hopefully they summarize it here, but the conclusion is that Mark will work on a patch.

01/25/08 19:40:14 changed by markjaquith

  • keywords set to has-patch.
  • status changed from new to assigned.
  • milestone changed from 2.5 to 2.3.3.

Here's the issue:

Windows Live Writer sends dateCreated without the "Z" designating is as a GMT date. WordPress assumes it is a local time, and post_date_gmt gets offset (by the WP-stored GMT offset).

Two things need to happen:

  1. Windows Live Writer needs to send the "Z" so we know it's GMT
  2. We need to give preference to date_created_gmt (which we can reasonably assume to be GMT even if it lacks the "Z") over dateCreated

Joseph is in contact with the WLW people about the first part, and I've created a patch to do the second part.

01/25/08 19:43:35 changed by markjaquith

  • attachment date_created_gmt__TRUNK.diff added.

For Trunk

01/25/08 19:49:04 changed by lloydbudd

  • milestone changed from 2.3.3 to 2.5.

Generally, we leave Milestone as trunk, until after it has 1st been fixed and vented there.

01/25/08 19:51:06 changed by josephscott

  • cc set to josephscott.

01/30/08 20:33:15 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6691]) Future post publishing over XML-RPC fixes from markjaquith. fixes #5721