Ticket #5764 (closed defect (bug): fixed)

Opened 1 year ago

Last modified 1 year ago

No way to upload if you don't use visual editor

Reported by: jhodgdon Assigned to: ryan
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch
Cc: jhodgdon, ffemtcj

Description (Last modified by lloydbudd)

In [6713], if you uncheck the box in your user profile that says "Use the visual editor", there is apparently no way to upload files or other images on the Write/Edit Post screen.

Steps to reproduce: I am using Firefox 2.0 on Windows. I log in as administrative user in my test blog. Click on "Users", and edit my user profile. Uncheck the box saying "Use the visual editor when writing". Save profile. Click on "Write" to write a new post. There is no section on the screen that I can find that will allow me to upload files.

If I then go back to my profile and turn on the visual editor (which I normally do not use, because I prefer to write my own clean HTML), there is now an "Add media" section, even if I switch to the "code" editor tab.

ADDITIONAL DETAILS (from Ryan)

The problem is in the_editor(). media-buttons is defined within a user_can_richedit() conditional.

Attachments

r6736_media_buttons.diff (0.6 kB) - added by ffemtcj on 02/06/08 11:48:50.
Fixes missing Add media when visual editor is not default
media-buttons-r6744.patch (0.7 kB) - added by tellyworth on 02/07/08 04:06:44.
alternate patch

Change History

02/04/08 16:08:44 changed by lloydbudd

jhodgdon, thank you for putting this in its own ticket!

Relates to #5609 New image uploader
nbachiyski, "If the user has disabled the visual editor from her profile, the Add media: bar isn't shown."

02/04/08 22:14:13 changed by lloydbudd

  • description changed.

02/06/08 11:48:50 changed by ffemtcj

  • attachment r6736_media_buttons.diff added.

Fixes missing Add media when visual editor is not default

02/06/08 11:49:21 changed by ffemtcj

  • cc changed from jhodgdon to jhodgdon, ffemtcj.
  • keywords changed from upload to has-patch.

02/07/08 01:08:35 changed by ryan

  • owner changed from anonymous to ryan.

02/07/08 04:06:44 changed by tellyworth

  • attachment media-buttons-r6744.patch added.

alternate patch

02/07/08 04:07:26 changed by tellyworth

Oops - didn't notice this ticket so I wound up fixing the same problem. Alternate patch included for whatever it's worth, no doubt the result is the same with both.

02/07/08 04:21:22 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6746]) Show media upload buttons when RTE is not enabled. Props tellyworth. fixes #5764