Ticket #5784 (closed defect (bug): fixed)

Opened 1 year ago

Last modified 1 year ago

List of Users on wp-admin/users.php has its headers skipped

Reported by: Potter_System Assigned to: markjaquith
Priority: lowest Milestone: 2.5
Component: General Version: 2.5
Severity: trivial Keywords: trivial wp-admin has-patch
Cc: ffemtcj

Description

On wp-admin/users.php, the table used to list users had its headers skipped (in English, the ID header was over Username values, and so on)

Attachments

users_table_skipped.patch (0.7 kB) - added by Potter_System on 02/07/08 00:48:15.
Editing values of th tags on users.php
5784.diff (1.7 kB) - added by markjaquith on 02/07/08 03:49:28.
Another solution
5784.jpeg (26.5 kB) - added by ffemtcj on 02/10/08 13:43:02.
Image showing incorrect alignment
r6778_user_administration.diff (1.3 kB) - added by ffemtcj on 02/10/08 13:43:26.
Patch fixing alignment issue

Change History

02/07/08 00:48:15 changed by Potter_System

  • attachment users_table_skipped.patch added.

Editing values of th tags on users.php

02/07/08 03:49:28 changed by markjaquith

  • attachment 5784.diff added.

Another solution

02/07/08 03:51:43 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.

I think it looks a little strange with the checkbox right next to the ID. It seems very different from similar interfaces I've seen where the checkboxes are clearly their own entity. See 5784.diff for a proposed solution.

02/07/08 03:54:40 changed by markjaquith

I like the idea. The patch should use the "update" method to take advantage of automatic SQL escaping.

02/07/08 04:08:00 changed by ffemtcj

See 5779. The patch created in that ticket sets the formatting to the same as it is in the current version of WP. I don't see a need to change the formatting since there is nothing to gain from it. I suggest marking this as a duplicate.

02/10/08 07:28:15 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6776]) Fix users table formatting. Props Potter_System and markjaquith. fixes #5784

02/10/08 13:42:41 changed by ffemtcj

  • cc set to ffemtcj.
  • status changed from closed to reopened.
  • resolution deleted.

#5784 does still does not correctly align the user list (see attached image). Also attached is a patch that will fix the alignment issue.

02/10/08 13:43:02 changed by ffemtcj

  • attachment 5784.jpeg added.

Image showing incorrect alignment

02/10/08 13:43:26 changed by ffemtcj

  • attachment r6778_user_administration.diff added.

Patch fixing alignment issue

02/14/08 20:32:50 changed by ffemtcj

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed r6852