Ticket #5855 (closed enhancement: fixed)

Opened 7 months ago

Last modified 7 months ago

Optimize generic_ping function

Reported by: fitztrev Assigned to: anonymous
Priority: low Milestone: 2.5
Component: Optimization Version:
Severity: normal Keywords: has-patch
Cc:

Description

The generic_ping function currently sends weblog_ping() a null value if there is an empty line in the ping_sites option. The regexp pattern in the function only replaces 2 or more empty lines with 1--it doesn't get rid of it altogether. There's no check anywhere down the line to stop the IXR class from trying to ping an empty string.

This restructure will address this problem and speed the function up at the same time.

Attachments

generic-ping.diff (0.7 kB) - added by fitztrev on 02/14/08 04:46:40.
Don't ping empty strings.

Change History

02/14/08 04:46:40 changed by fitztrev

  • attachment generic-ping.diff added.

Don't ping empty strings.

02/14/08 20:16:22 changed by lloydbudd

  • keywords set to has-patch.

02/14/08 21:50:44 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6853]) generic_ping() improvements from fitztrev. fixes #5855