Ticket #5868 (closed defect (bug): fixed)

Opened 11 months ago

Last modified 11 months ago

Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs

Reported by: hempsworth Assigned to: hempsworth
Priority: low Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

The main navigation tabs don't look completely right, with blue borders on the bottom of them and a blue border on the bottom of selected tabs. http://i243.photobucket.com/albums/ff32/hempsworth/tabs.jpg

Also, a strange bug in IE6 which causes a blue background/border on the current submenu item. http://i243.photobucket.com/albums/ff32/hempsworth/submenu.jpg

Both are fixed in the attached patch.

Attachments

navigation-bugfix.patch (1.8 kB) - added by hempsworth on 02/15/08 19:23:22.
Patch for both bugs
tabs.jpg (6.0 kB) - added by hempsworth on 02/15/08 23:24:43.
The tabs bug
submenu.jpg (6.3 kB) - added by hempsworth on 02/15/08 23:25:14.
The submenu IE6 bug
before-after.png (53.8 kB) - added by hempsworth on 02/16/08 11:20:25.
Before and after, with hover over
admin-menu.gif (43 bytes) - added by hempsworth on 02/16/08 13:45:55.
Oops, forgot to attach the 1x1px gif used as a background image!
patched-tabs.png (5.7 kB) - added by Speedboxer on 02/17/08 00:44:47.
What my tabs look like after this patch, in IE7 on Vista
double-underline-fix.patch (408 bytes) - added by hempsworth on 02/17/08 03:32:05.
5868.diff (1.1 kB) - added by Speedboxer on 02/17/08 05:06:58.
Fix bugs in various browsers

Change History

02/15/08 19:23:22 changed by hempsworth

  • attachment navigation-bugfix.patch added.

Patch for both bugs

02/15/08 19:27:25 changed by hempsworth

  • owner changed from anonymous to hempsworth.
  • status changed from new to assigned.

02/15/08 19:28:33 changed by lloydbudd

  • keywords set to has-patch.
  • summary changed from Main navigation bugfix to Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs.
  • version set to 2.5.
  • milestone changed from 2.6 to 2.5.

02/15/08 19:28:43 changed by lloydbudd

  • summary changed from Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs to Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs.

02/15/08 21:05:50 changed by ryan

Can you attach the image?

02/15/08 23:24:43 changed by hempsworth

  • attachment tabs.jpg added.

The tabs bug

02/15/08 23:25:14 changed by hempsworth

  • attachment submenu.jpg added.

The submenu IE6 bug

02/16/08 04:53:03 changed by Speedboxer

I thought that border was intentional... Looks good with it. It also further distinguishes a tab you're hovering over, and a selected tab.

02/16/08 11:20:25 changed by hempsworth

  • attachment before-after.png added.

Before and after, with hover over

02/16/08 11:24:52 changed by hempsworth

The attached image shows the tabs before and after the patch is applied, with an active and hovered over tab; I think this was the intended effect in the first place.

02/16/08 13:45:55 changed by hempsworth

  • attachment admin-menu.gif added.

Oops, forgot to attach the 1x1px gif used as a background image!

02/16/08 22:39:59 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6880]) Tab styling fixes from hempsworth. fixes #5868

02/16/08 23:17:06 changed by Speedboxer

  • status changed from closed to reopened.
  • resolution deleted.

The patch creates a double-underline in both IE7 and FF2. It's fine in Safari (for Windows), though.

(follow-up: ↓ 10 ) 02/17/08 00:33:06 changed by hempsworth

Hmm, are you sure you did a hard refresh etc. I just downloaded a fresh copy of trunk and it's working fine for me in:

  • FF2
  • Safari 3 (Windows)
  • IE7
  • IE6

Could you post a screenshot if the problem persists, thanks!

02/17/08 00:44:47 changed by Speedboxer

  • attachment patched-tabs.png added.

What my tabs look like after this patch, in IE7 on Vista

(in reply to: ↑ 9 ) 02/17/08 00:46:45 changed by Speedboxer

Replying to hempsworth:

Hmm, are you sure you did a hard refresh etc. I just downloaded a fresh copy of trunk and it's working fine for me in: * FF2 * Safari 3 (Windows) * IE7 * IE6 Could you post a screenshot if the problem persists, thanks!

Yep, did a hard refresh, and reverted all modifications. I've attached a screenshot of what it looks like on the Dashboard (left) and what it looks like on the Write page with the mouse over Design (right). This is in IE7 on Vista, looks like same in FF2.

02/17/08 00:51:37 changed by ryan

I had the double underline before, but the patch fixed it for FF2 and Safari on Mac. Go fig.

02/17/08 00:59:16 changed by Speedboxer

Just checked it in IE6 on XP, same problem.

02/17/08 01:10:10 changed by Speedboxer

Same problem in FF2 on XP and Opera on Vista.

02/17/08 02:49:00 changed by Speedboxer

The latest patch fixes the double-underline. Just one more problem, the bottom of the hover box doesn't line up with the whole bottom border. If that makes sense.

(follow-up: ↓ 16 ) 02/17/08 02:59:40 changed by hempsworth

Yep that makes sense :) Try the revised version of double-underline-fix.patch

(in reply to: ↑ 15 ) 02/17/08 03:06:22 changed by Speedboxer

Replying to hempsworth:

Yep that makes sense :) Try the revised version of double-underline-fix.patch

I think either the whole border needs to be moved down a px, or the tabs need to be moved up a px...

02/17/08 03:31:51 changed by hempsworth

The following patch is backtracking slightly and trying to fix:

the bottom of the hover box doesn't line up with the whole bottom border

...in a different way. Could you try this patch, and if it doesn't work, post a screenshot.

02/17/08 03:32:05 changed by hempsworth

  • attachment double-underline-fix.patch added.

02/17/08 05:06:58 changed by Speedboxer

  • attachment 5868.diff added.

Fix bugs in various browsers

02/17/08 05:08:52 changed by Speedboxer

My patch fixes the problems. Except in Safari (for Windows) there's a small 1px gap between the bottom of the hover tab and the bottom border... I tested it in these browsers:

IE6 on XP IE7 on Vista Opera on Vista FF2 on XP and Vista Safari on Vista

02/17/08 13:28:14 changed by hempsworth

Nice one, your patch works a treat!

02/17/08 19:41:52 changed by ryan

(In [6884]) Tab styling fixes from Speedboxer. see #5868

02/17/08 19:44:17 changed by ryan

(In [6885]) Removed no longer needed image. see #5868

02/26/08 08:59:38 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.