Ticket #5890 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Theme editor font sizing and layout errors

Reported by: ionfish Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: theme-editor has-patch needs-testing
Cc:

Description

This patch makes the theme editor present its fonts in a more Safari-friendly way (currently the code in the textarea is very small); I've followed the convention elsewhere to set the fonts in pixels, but I can attach an additional patch to allow resizing in IE6 if required.

Additionally, when the list of files is longer than the textarea, the "You need to make this file writable" text overflows the left column into the list of files. The attached patch restricts the text to the left column.

Attachments

template_layout.patch (1.3 kB) - added by ionfish on 02/17/08 10:36:05.
templateside_layout.patch (428 bytes) - added by ionfish on 02/18/08 21:52:45.
remove_small.diff (0.9 kB) - added by ionfish on 02/19/08 20:53:24.

Change History

02/17/08 10:36:05 changed by ionfish

  • attachment template_layout.patch added.

02/17/08 22:23:04 changed by ryan

(In [6890]) Theme editor font sizing and layout fixes from ionfish. see #5890

02/17/08 22:35:52 changed by ryan

Also, after doing "Update File" the confirmation message at the top messes up layout.

02/18/08 21:52:45 changed by ionfish

  • attachment templateside_layout.patch added.

02/18/08 21:54:36 changed by ionfish

  • keywords changed from theme-editor has-patch to theme-editor has-patch needs-testing.

Needs testing in Internet Explorer; works ok on Saf3/Mac and FF2/Mac.

02/19/08 00:00:53 changed by ryan

(In [6908]) Theme editor layout fixes from ionfish. see #5890

02/19/08 00:01:18 changed by ryan

I don't have IE, but committed to make it easier for those that do to test.

02/19/08 00:23:22 changed by ryan

From the tester's list: 

On the "Theme Files" list, an unneeded </small> tag is included after
the "nonessential" span.

<li><a href="theme-editor.php?file=...">404 Template <span class='nonessential'>(404.php)</span>/*</small>*/</a></li>

02/19/08 20:53:24 changed by ionfish

  • attachment remove_small.diff added.

02/21/08 21:49:49 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6960]) Remove extraneous tag. Props ionfish. fixes #5890