Ticket #5906 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Border radius not specified for all browsers

Reported by: iammattthomas Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: General Version:
Severity: normal Keywords: has-patch
Cc:

Description

Where -moz-border-radius is specified, -khtml-border-radius should be specified as well.

Attachments

wp-admin.css.diff (1.9 kB) - added by iammattthomas on 02/18/08 23:46:54.
Patch adds border radiuses for KHTML
dashboard.css.diff (362 bytes) - added by iammattthomas on 02/19/08 00:35:53.
Patch border radius for webkit
wp-admin-css.diff (2.3 kB) - added by iammattthomas on 02/19/08 00:36:02.
Patch border radius for webkit
dashboard.css.2.diff (502 bytes) - added by iammattthomas on 02/19/08 18:32:09.
Patch reflects sambauers suggestion for specifying radiuses
wp-admin.css.2.diff (3.8 kB) - added by iammattthomas on 02/19/08 18:32:15.
Patch reflects sambauers suggestion for specifying radiuses

Change History

02/18/08 23:46:54 changed by iammattthomas

  • attachment wp-admin.css.diff added.

Patch adds border radiuses for KHTML

02/18/08 23:53:31 changed by technosailor

I think you mean -webkit-border-radius which is Safari 3 implementation. Konqueror uses the former, as did <Safari 2. But come on, who uses Konqueror?

I'm of the mind that no broswer-specific CSS3 declarations should be used so I'm -1 all the way around, but if we're going to do it, we might as well use the more common CSS3 declaration used by more people and that's the webkit variant.

02/19/08 00:29:31 changed by iammattthomas

I'm fine with -webkit, just chose -khtml as it was already in use elsewhere. I'll change. As to including it altogether, I think it makes sense to use it where we can for the browsers that support it.

02/19/08 00:35:53 changed by iammattthomas

  • attachment dashboard.css.diff added.

Patch border radius for webkit

02/19/08 00:36:02 changed by iammattthomas

  • attachment wp-admin-css.diff added.

Patch border radius for webkit

02/19/08 00:38:32 changed by sambauers

It might be best to future proof border-radius declarations using this order... 

-moz-border-radius: XXX
-khtml-border-radius: XXX
-webkit-border-radius: XXX
border-radius: XXX

For now Firefox picks up the first, Konqueror picks up the second, Safari picks up the second or third and in time they (and hopefully others) will all pick up the last CSS3 "standard" one.

02/19/08 00:47:59 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6909]) Add webkit border radius. Props mt. fixes #5906

02/19/08 00:48:42 changed by ryan

Missed sambauers comment before committing. Reopen if we want to change this.

02/19/08 08:56:32 changed by matt

  • status changed from closed to reopened.
  • resolution deleted.

Yeah let's standardize on that that.

02/19/08 17:08:11 changed by lloydbudd

  • keywords set to sambauers.
  • milestone changed from 2.6 to 2.5.

02/19/08 18:32:09 changed by iammattthomas

  • attachment dashboard.css.2.diff added.

Patch reflects sambauers suggestion for specifying radiuses

02/19/08 18:32:15 changed by iammattthomas

  • attachment wp-admin.css.2.diff added.

Patch reflects sambauers suggestion for specifying radiuses

02/19/08 18:33:13 changed by iammattthomas

Attached patches that specify radius as sambauers suggested above.

02/19/08 18:36:14 changed by iammattthomas

  • keywords changed from sambauers to has-patch.

02/19/08 20:31:14 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6917]) Border radius changes from mt. fixes #5906