Ticket #5961 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Fix some notices

Reported by: nbachiyski Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: General Version:
Severity: normal Keywords: notices has-patch needs-testing
Cc:

Description

Last night I turned debugging on and fought with some notices.

In most of the places there are just issets added, but at some places there are more complicated cases, which need review and some testing.

Attachments

notices.diff (14.6 kB) - added by nbachiyski on 02/22/08 11:02:16.
5961.diff (0.9 kB) - added by fitztrev on 02/24/08 00:54:48.
Reverting the change to wp-inc/canonical.php makes it work.

Change History

02/22/08 11:02:16 changed by nbachiyski

  • attachment notices.diff added.

02/22/08 17:43:57 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [6983]) Notice fixes from nbachiyski. fixes #5961

02/24/08 00:35:48 changed by fitztrev

  • status changed from closed to reopened.
  • resolution deleted.

After r6983, the links on my site that used my old permalink structure result in 404s. Prior to this change, the old links would automatically redirect to the new permalink structure and find the post correctly.

02/24/08 00:54:48 changed by fitztrev

  • attachment 5961.diff added.

Reverting the change to wp-inc/canonical.php makes it work.

02/24/08 02:09:24 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6998]) Revert changes to canonical that broke redirects. Props fitztrev. fixes #5961

02/24/08 23:36:49 changed by nbachiyski

The problem is in these two lines: 

$original['query'] = isset($redirect['query'])? $redirect['query'] : false; 
$original['port'] = isset($redirect['port'])? $redirect['port'] : false;

Here I am filling $original with $redirect's values.

Copy-paste after midnight should be avoided :-)

02/27/08 03:33:29 changed by darkdragon

  • milestone changed from 2.6 to 2.5.

03/05/08 18:58:39 changed by andy

sanitize_post changes broke filtering of new posts, reverted in [7161]