Ticket #5973 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Admin should use semantic classes

Reported by: filosofo Assigned to: iammattthomas
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: css semantic-markup has-patch
Cc: filosofo

Description

As explained here, semantic class names should reflect function, not a particular style. So for example "niceblue" isn't such a great class name, as a differently-styled admin page might not even use blue there.

WordPress advertises itself as a "semantic personal publishing platform", and there is at least one ''A List Apart'' article supporting semantic class names (A List Apart is of course published by Happy Cog, the designers of the new WP admin theme), so this should be a part of the new WordPress design.

Attachments

remove_niceblue_class.diff (15.1 kB) - added by filosofo on 02/23/08 23:07:30.
form-table.diff (15.1 kB) - added by iammattthomas on 02/24/08 04:11:33.
Patches #5973 with .form-table class replacing .niceblue

Change History

02/23/08 23:07:30 changed by filosofo

  • attachment remove_niceblue_class.diff added.

02/23/08 23:10:04 changed by filosofo

Please let's fix this before the 2.5 release, as once it's out there, we plugin authors will be saddled with it for a long time. There's already someone telling plugin authors to use "niceblue" in preparation for 2.5.

02/24/08 02:19:09 changed by ryan

  • owner changed from anonymous to iammattthomas.

I pinged MT for some HC feedback. Changing it is a perl script away once a new name is decided upon.

02/24/08 02:20:03 changed by ryan

Or, one patch -p0 away since you attached a diff. :-)

02/24/08 04:10:59 changed by iammattthomas

I agree completely; I'm going to suggest the name .form-table for the sake of specificity.

02/24/08 04:11:33 changed by iammattthomas

  • attachment form-table.diff added.

Patches #5973 with .form-table class replacing .niceblue

02/24/08 04:14:49 changed by filosofo

Perfect! Thanks.

02/24/08 04:33:10 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7000]) Change niceblue class name to form-table. Props filosofo and mt. fixes #5973