Ticket #5985 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Styling Manage Comments page

Reported by: iammattthomas Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: General Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

CSS for Manage Comments page.

Attachments

5985.diff (6.3 kB) - added by iammattthomas on 02/24/08 18:02:12.
5985-2.diff (2.3 kB) - added by iammattthomas on 02/25/08 00:14:45.
Move updated div above .wrap for consistency with other pages
5985-2.2.diff (2.7 kB) - added by iammattthomas on 02/25/08 00:19:49.

Change History

02/24/08 18:02:12 changed by iammattthomas

  • attachment 5985.diff added.

(follow-up: ↓ 3 ) 02/24/08 18:15:13 changed by iammattthomas

As far as I can tell, there's no way to split onelongwordwithnospaces with CSS (currently). So the URL will need to be trimmed down in the source.

Added some code to apply a "class='current'" to the Detail View/List View switcher, might want to look at that and make sure it's kosher (it works, but I don't know enough PHP to know if my style is good).

Where it says "From [post name], [Date] at [Time]," that should read "From [post name], [N hours/minutes ago]" for comments posted today; and "From [post name] at [time]" for all others. The date should be taken out since it's got its own column.

The separate moderation.php page, as far as I can tell, should be deprecated in favor of edit-comments.php?comment_status=moderated. Happy Cog didn't provide a design for the moderation page so as I understand it, all moderation should be handled via this new form.

02/24/08 19:41:05 changed by ryan

(In [7005]) Manage comments styling from mt. see #5985

(in reply to: ↑ 1 ) 02/24/08 19:47:27 changed by ryan

Replying to iammattthomas:

As far as I can tell, there's no way to split onelongwordwithnospaces with CSS (currently). So the URL will need to be trimmed down in the source.

I'll trim it.

Added some code to apply a "class='current'" to the Detail View/List View switcher, might want to look at that and make sure it's kosher (it works, but I don't know enough PHP to know if my style is good).

Looks good.

Where it says "From [post name], [Date] at [Time]," that should read "From [post name], [N hours/minutes ago]" for comments posted today; and "From [post name] at [time]" for all others. The date should be taken out since it's got its own column.

I'll add the human time. The separate date column is for the comment's date. The date in the from line is the post's date. I think we need both.

The separate moderation.php page, as far as I can tell, should be deprecated in favor of edit-comments.php?comment_status=moderated. Happy Cog didn't provide a design for the moderation page so as I understand it, all moderation should be handled via this new form.

I think it's going away. I'll remove it once I finish hooking up all the buttons in edit-comments.php and we fix the AJAX interactions. Akismet will also need to change to put the recheck queue link on edit-comments.php.

02/25/08 00:14:45 changed by iammattthomas

  • attachment 5985-2.diff added.

Move updated div above .wrap for consistency with other pages

02/25/08 00:15:57 changed by iammattthomas

Added new patch that moves .updated above .wrap so it doesn't interfere with the .view-switch.

02/25/08 00:19:49 changed by iammattthomas

  • attachment 5985-2.2.diff added.

02/25/08 00:28:22 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7011]) Manage comments styling from mt. fixes #5985