Ticket #6009 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

edit-comments.php ajax actions need tweaking

Reported by: mdawaffe Assigned to: mdawaffe
Priority: high Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: js ajax has-patch
Cc:

Description

  1. Deleting comments looks strange; the JS effect is broken.
  2. Approving comments from "All comments" page makes them disappear.
  3. Approving comments doesn't update all of the "awaiting moderation" counts on the page.

Attached:

  1. Replaces jquery.color.js with version from trunk: http://dev.jquery.com/browser/trunk/plugins/color/jquery.color.js. This improves RGBA support which is necessary for Safari 3. It's still broken (http://dev.jquery.com/ticket/2281), but at least it doesn't completely die anymore.
  2. Cleans up background-color fades in wp-lists.js.
  3. Tidies up wp-lists.js to be more jQuery 1.2 friendly.
  4. Clean up wp-list's delete JS. slideUp doesn't work on TRs or other table elements (a known jQuery bug). Use fadeOut for these elements.
  5. Approve comments from "All comments" makes them glow and lose their "approve" link (rather than glowing and disappearing completely).
  6. Updates comment-count markup and JS so that all comment-count ("awaiting moderation") numbers get incremented/decremented correctly.

Attachments

6009.diff (23.7 kB) - added by mdawaffe on 02/26/08 22:24:41.

Change History

02/26/08 22:24:41 changed by mdawaffe

  • attachment 6009.diff added.

02/26/08 22:26:10 changed by mdawaffe

  • owner changed from anonymous to mdawaffe.
  • status changed from new to assigned.

jquery.color.js will need to be re-minified if we want to keep doing that.

So far, everything's only been tested in FF 2.

02/26/08 22:45:47 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7050]) Ajax tweaks for edit-comments.php from mdawaffe. fixes #6009