Ticket #6121 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

RTL CSS in Login

Reported by: Ali_ix Assigned to: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: rtl login css has-patch
Cc:

Description

Please include the 'login-rtl.css' file in login page after 'login.css' file. And please remove the 'dir="rtl"' property on html tag there.

Attachments

login-rtl-css.diff (0.5 kB) - added by nbachiyski on 03/10/08 07:05:46.

Change History

03/10/08 07:05:46 changed by nbachiyski

  • attachment login-rtl-css.diff added.

03/10/08 07:09:56 changed by nbachiyski

  • keywords changed from rtl login css to rtl login css has-patch.
  • milestone changed from 2.6 to 2.5.

Attached is a patch, which loads login-rtl.css if we have the proper $text_direction.

Why shall we remove dir="rtl"?

03/10/08 07:11:44 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7203]) Include login rtl css. Props nbachiyski. fixes #6121

03/10/08 07:59:42 changed by Ali_ix

Thanks for the fix.

Since we can handle the page direction in CSS, it would be unnecessary (dir="rtl"). By the way, it isn't an issue and it works.