Ticket #6206 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Headers already sent error in media.php

Reported by: darkfate Assigned to: andy
Priority: normal Milestone: 2.5
Component: Administration Version:
Severity: blocker Keywords: bg|has-patch
Cc:

Description

Getting headers already sent:

Warning: Cannot modify header information - headers already sent by (output started at C:\Apache2\htdocs\wp\wp-admin\media.php:63) in C:\Apache2\htdocs\wp\wp-includes\pluggable.php on line 687

Attachments

media.php.diff (429 bytes) - added by darkfate on 03/13/08 21:55:19.
assume this is what is intended?
6206-css.diff (331 bytes) - added by andy on 03/17/08 18:16:26.
fix missing menu items
6206.diff (264 bytes) - added by mdawaffe on 03/17/08 18:25:56.
headers error
6206-warning.diff (0.6 kB) - added by andy on 03/17/08 18:26:20.
default case comes last

Change History

03/13/08 21:55:19 changed by darkfate

  • attachment media.php.diff added.

assume this is what is intended?

03/13/08 22:22:15 changed by darkfate

  • keywords set to has-patch.

03/13/08 22:23:41 changed by darkfate

  • keywords changed from has-patch to bg|has-patch.

03/13/08 22:31:17 changed by mdawaffe

I would just put an exit; after the require( 'admin-footer.php' ); for now.

That way browsing to just media.php won't give you a blank page.

03/16/08 17:23:59 changed by KirkM

I'm still getting the warning message using the test scenario below and although putting exit; after require( 'admin-footer.php' ); eliminates the "Warning" at the bottom of the image editing page (Manage/Media Library), the "Settings", "Plugins" and "Users" links are still missing from the top of the page. Please see below for details...

In the "Manage/MediaLibrary", when selecting any link in the "Media" column which brings up the selected image's edit page, at that point "Settings", "Plugins" and "Users" links disappear from the top right of page and the following warning is displayed at the bottom of the page on these two sites (same host): (all plugins deactivated-both tests, both sites.

Main site running Trunk build r7331:

Warning*: Cannot modify header information - headers already sent by (output started at /home/longmead/public_html/just-thinkin/wp-admin/admin-header.php:26) in */home/longmead/public_html/just-thinkin/wp-includes/pluggable.php* on line *688

Test site 2 running Trunk build r7298:

*Warning*: Cannot modify header information - headers already sent by (output started at /home/longmead/public_html/just-thinkin/wp25-test/wp-admin/admin-header.php:26) in */home/longmead/public_html/just-thinkin/wp25-test/wp-includes/pluggable.php* on line *687

Since the warning is still showing up, is this really slated to be fixed for version 2.6?

03/16/08 18:24:38 changed by ryan

  • owner changed from anonymous to andy.

03/16/08 18:43:15 changed by darkfate

  • milestone changed from 2.6 to 2.5.

03/17/08 18:11:06 changed by andy

The disappearing menu items are probably due to a CSS conflict on that page. Working on a patch.

(follow-up: ↓ 10 ) 03/17/08 18:12:18 changed by andy

I do not see any warnings on that page as of [7345]. Please confirm and give more info on reproducing the problem.

03/17/08 18:16:26 changed by andy

  • attachment 6206-css.diff added.

fix missing menu items

03/17/08 18:25:56 changed by mdawaffe

  • attachment 6206.diff added.

headers error

03/17/08 18:26:20 changed by andy

  • attachment 6206-warning.diff added.

default case comes last

03/17/08 18:28:43 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7346]) Fix warning in media.php. Show sidemenu. Props andy. fixes #6206

(in reply to: ↑ 8 ) 03/17/08 19:07:04 changed by KirkM

Replying to andy:

I do not see any warnings on that page as of [7345]. Please confirm and give more info on reproducing the problem.

Nice job on the fix, Andy but since you asked--as of r7343, the warnings disappeared and only the "sidemenu"(?) was still missing. I just loaded and tested r7346 and all is well. I was away at the moment hence my late reply.