Ticket #6209 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Adding a category crashes the editor

Reported by: Denis-de-Bernardy Assigned to: mdawaffe
Priority: highest omg bbq Milestone: 2.5
Component: Administration Version: 2.5
Severity: blocker Keywords: js has-patch needs-testing
Cc:

Description (Last modified by lloydbudd)

Procedure to reproduce using Camino on a Mac:

1. Create a post, assign it the "test" tag
2. Publish the post
3. Edit the post, assign it a **newly created** "Test" category
4. The save button no longer responds
5. Upon browsing back to the editor, the category "test" (lowercase) got created but isn't assigned to the post

I more or less recall noticing a similar bug in WP 2.3, using FF on Windows. It likely applies to FF on Linux and to IE as well, since a workflow issue is arguably underneath.

Attachments

6209.diff (6.7 kB) - added by mdawaffe on 03/18/08 19:16:48.
6209.b.diff (7.2 kB) - added by mdawaffe on 03/18/08 19:19:10.
Now with cache busting
6209.c.diff (0.8 kB) - added by mdawaffe on 03/18/08 19:34:12.

Change History

03/14/08 01:06:37 changed by lloydbudd

  • priority changed from normal to high.
  • component changed from Administration to TinyMCE.
  • description changed.

Denis-de-Bernardy, please, please include the version / subversion revision you are using. Thank you!

(follow-up: ↓ 4 ) 03/14/08 07:33:58 changed by Denis-de-Bernardy

Sorry about that! I was assuming that, upon selecting version 2.5, the fact I was testing trunk was obvious. ;-)

It's still occurring this morning by the way (rev 7283).

03/14/08 10:54:20 changed by sambauers

Confirmed in [7290]

(in reply to: ↑ 2 ) 03/14/08 15:07:04 changed by lloydbudd

Replying to Denis-de-Bernardy:

Sorry about that! I was assuming that, upon selecting version 2.5, the fact I was testing trunk was obvious. ;-)

Trunk is a rapidly moving target, including the revision is always desirable.

03/16/08 05:23:18 changed by fergbrain

I can confirm this error occurs with FF 2.0.0.11 on Windows Server 2K3 and WP build 7326. My gut says that it may be an issue related to how the form tag is nested, or perhaps JS?

03/18/08 15:25:33 changed by MtDewVirus

Tested with r7379 on FF2 and Safari 3.1...

If you write a new post and add it to a new category, the Save and Publish buttons do not respond. Similarly if you write a new link and add a new category to it, the Save button does not respond.

03/18/08 15:31:21 changed by lloydbudd

  • priority changed from high to highest omg bbq.
  • severity changed from major to blocker.

03/18/08 16:01:58 changed by MichaelH

Can confirm this happens with 2.5-RC1 with "use the visual editor when writing" checked and with this browser: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12

03/18/08 18:57:43 changed by mdawaffe

  • owner changed from anonymous to mdawaffe.
  • status changed from new to assigned.

This may have been caused by [7262]. Investigating now.

03/18/08 19:16:22 changed by mdawaffe

  • keywords set to js.
  • component changed from TinyMCE to Administration.

6209.diff

Confirmed this was caused by over-aggressive form validation from [7262]. Attached makes form validation opt-in with .validate class.

03/18/08 19:16:48 changed by mdawaffe

  • attachment 6209.diff added.

03/18/08 19:17:22 changed by mdawaffe

  • keywords changed from js to js has-patch needs-testing.

03/18/08 19:19:10 changed by mdawaffe

  • attachment 6209.b.diff added.

Now with cache busting

03/18/08 19:20:19 changed by ryan

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7384]) Fix over-aggressive form validation. Props mdawaffe. fixes #6209

03/18/08 19:34:00 changed by mdawaffe

  • status changed from closed to reopened.
  • resolution deleted.

6209.c.diff

Reverts wp-admin/edit-link-form.php. This form should not be run through the aggressive validator for the same reason the post form should not be.

03/18/08 19:34:12 changed by mdawaffe

  • attachment 6209.c.diff added.

03/18/08 19:37:32 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [7385]) Fix over-aggressive form validation. Props mdawaffe. fixes #6209