Ticket #6213 (new defect)

Opened 8 months ago

Last modified 8 months ago

widget.php includes wrong javascript tag for category dropdown

Reported by: reppep Assigned to: anonymous
Priority: normal Milestone: 2.9
Component: Template Version: 2.3.3
Severity: normal Keywords: validation
Cc:

Description

The Category dropdown uses JavaScript?, and embeds it using the wrong (old?) syntax. Patch:

[root@inspector wp-includes]# diff -u widgets.php.ORIG widgets.php --- widgets.php.ORIG 2008-03-13 22:18:25.000000000 -0400 +++ widgets.php 2008-03-13 22:19:10.000000000 -0400 @@ -630,7 +630,7 @@

wp_dropdown_categories($cat_args . '&show_option_none= ' . ('Select Category'));

?>

-<script lang='javascript'><!-- +<script type="text/javascript"><!--

var dropdown = document.getElementById("cat"); function onCatChange() {

if ( dropdown.options[dropdown.selectedIndex].value > 0 ) {

Change History

03/14/08 15:12:13 changed by hansengel

I couldn't find the mistake that your describing in wp-includes/widgets.php with r7290.

Also, for future reference, please run a command like this: 

svn diff > myPatchFile.diff

Then just attach that file. This way SVN handles it and it is much easier to read (when it is uploaded, we can view it using the Diff Viewer on Trac).