Ticket #6228 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Reduce dependency on inline style

Reported by: mdawaffe Assigned to: mdawaffe
Priority: normal Milestone: 2.5
Component: General Version: 2.5
Severity: normal Keywords: css rtl has-patch commit
Cc:

Description

The new design implementation has a lot of inline style. WordPress has historically stayed away from inline styling to aid skinners and, more importantly, RTL users.

Attached:

  1. Uses alignleft and alignright classes instead of hardcoded floats.
  2. Uses new textleft and textright classes instead of hardcoded text-aligns.
  3. Uses check-column and new num class to center those table columns rather than hardcoded text-aligns. Also simplifies and standardizes check-column markup.
  4. Replaces <br style="clear: both;" /> with <br class="clear" />.
  5. Uses new button-highlighted class instead of hardcoded font-weights.
  6. Adds to css/theme-editor.css file to get rid of hardcoded styling in the theme and plugin editors.

Attachments

6228.diff (28.4 kB) - added by mdawaffe on 03/14/08 23:54:40.
6228.b.diff (6.5 kB) - added by mdawaffe on 03/15/08 00:18:06.

Change History

03/14/08 23:54:40 changed by mdawaffe

  • attachment 6228.diff added.

03/14/08 23:58:32 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7304]) Reduce dependency on inline style. Props mdawaffe. fixes #6228

03/14/08 23:59:50 changed by mdawaffe

  • status changed from closed to reopened.
  • resolution deleted.

Couple of minor bugs. I'll have a patch soon.

03/15/08 00:18:06 changed by mdawaffe

  • attachment 6228.b.diff added.

03/15/08 00:18:33 changed by mdawaffe

  • keywords changed from css rtl to css rtl has-patch commit.
  • owner changed from anonymous to mdawaffe.
  • status changed from reopened to new.

03/15/08 06:14:03 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7307]) Reduce dependency on inline style. Props mdawaffe. fixes #6228