Ticket #6271 (assigned defect)

Opened 7 months ago

Last modified 1 month ago

Add WordPress logo to wp_die()

Reported by: DD32 Assigned to: markjaquith (accepted)
Priority: normal Milestone: 2.9
Component: General Version: 2.5
Severity: normal Keywords: has-patch 2nd-opinion dev-feedback
Cc:

Description

Patch adds a WordPress logo to wp_die().

A 3rd parameter has been added to allow turning the logo off. Not that i'm sure what need there is for it(I was originally going to opt-in for the logo).

I'm leaving this marked as a defect as i'd expect a logo to be shown on the error page myself, it tells me who the error is coming from.

Attachments

6271.diff (1.7 kB) - added by DD32 on 03/18/08 04:25:08.

Change History

03/18/08 04:25:08 changed by DD32

  • attachment 6271.diff added.

03/18/08 04:25:32 changed by DD32

Patch also has an indentation fix.

03/19/08 06:08:20 changed by markjaquith

  • owner changed from anonymous to markjaquith.
  • status changed from new to assigned.

+1. Nice to know the source of error messages, plus it looks pretty. Want to hear other opinions on the matter.

03/19/08 18:25:34 changed by filosofo

I think the point is to avoid giving WordPress the blame every time someone's DB dies under the digg effect.

03/20/08 00:19:02 changed by DD32

I think the point is to avoid giving WordPress the blame every time someone's DB dies under the digg effect.

Database Dead messages to guests just get a bland "Error connecting to database" now, Nothing pretty, try it, Give a 2.5 install a bad database credential, then hit the home page, then hit the admin page, you'll see the difference.

If someone accesses the admin interface and the database is dead, it explains that WordPress is having difficulty connecting and whatnot.

09/13/08 08:39:54 changed by DD32

Any traction?

Or should this be closed off as a wontfix?