Ticket #6280 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Attachment permalinks with int slugs fail

Reported by: andy Assigned to: ryan
Priority: high Milestone: 2.5
Component: General Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

http://www.gamesgorilla.com/2008/03/18/testing/

Attachment slugs should not be allowed to be ints.

Possible fix: if type is attachment and $slug is int, make it "attachment-$slug"

Attachments

6280screen1.jpg (78.9 kB) - added by MtDewVirus on 03/18/08 18:37:01.
6280screen2.jpg (77.1 kB) - added by MtDewVirus on 03/18/08 18:37:32.
Notice the same content is loaded and displayed for both attachment URLs
6280.diff (0.7 kB) - added by andy on 03/21/08 03:01:44.
use explicit attachment permalink marker for int names

Change History

03/18/08 18:37:01 changed by MtDewVirus

  • attachment 6280screen1.jpg added.

03/18/08 18:37:32 changed by MtDewVirus

  • attachment 6280screen2.jpg added.

Notice the same content is loaded and displayed for both attachment URLs

03/21/08 03:01:44 changed by andy

  • attachment 6280.diff added.

use explicit attachment permalink marker for int names

03/21/08 03:04:20 changed by andy

  • keywords set to has-patch.
  • owner changed from anonymous to ryan.

Clean solution: use http://trac.wordpress.org/browser/trunk/wp-includes/rewrite.php?rev=6964#L717

03/21/08 03:08:22 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7437]) use explicit attachment permalink marker for int names. Props andy. fixes #6280