Ticket #6296 (closed defect: fixed)

Opened 8 months ago

Last modified 5 months ago

RTL CSS for 2.5

Reported by: nbachiyski Assigned to: anonymous
Priority: normal Milestone: 2.6
Component: General Version:
Severity: normal Keywords: has-patch
Cc:

Description

Prepared by Mani Monajjemi.

Attachments

rtl-for-25.diff (8.3 kB) - added by nbachiyski on 03/19/08 07:04:50.
wp-admin-rtl.zip (7.7 kB) - added by nbachiyski on 03/19/08 07:05:53.
The whole zip will be more convinient.
wp-admin-rtl-edit2.patch (3.3 kB) - added by mani_monaj on 03/22/08 17:40:23.
New Improvements
colors-rtl-fix.patch (467 bytes) - added by mani_monaj on 03/22/08 18:28:44.
Colors RTL fix
wp-admin-rtl-edit3.patch (6.4 kB) - added by mani_monaj on 03/23/08 22:14:02.
Improvements
wp-admin-rtl-edit4.patch (1.5 kB) - added by mani_monaj on 03/27/08 20:32:44.
kubrick-rtl.css (1.7 kB) - added by mani_monaj on 03/27/08 20:38:17.
New Kubrik's rtl.css

Change History

03/19/08 07:04:50 changed by nbachiyski

  • attachment rtl-for-25.diff added.

03/19/08 07:05:53 changed by nbachiyski

  • attachment wp-admin-rtl.zip added.

The whole zip will be more convinient.

03/19/08 16:08:04 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7398]) RTL CSS from Mani. fixes #6296

03/22/08 17:40:23 changed by mani_monaj

  • attachment wp-admin-rtl-edit2.patch added.

New Improvements

03/22/08 17:41:55 changed by mani_monaj

  • status changed from closed to reopened.
  • resolution deleted.

I added a patch. It improves some bugs on IE & Upload Page.

03/22/08 17:59:55 changed by ryan

(In [7476]) RTL CSS from mani_monaj. see #6296

(follow-up: ↓ 5 ) 03/22/08 18:01:09 changed by ryan

I'm not sure if the colors rtl css is being loaded correctly. I think wp_admin_css_uri() needs to be fixed.

(in reply to: ↑ 4 ) 03/22/08 18:28:10 changed by mani_monaj

Replying to ryan:

I'm not sure if the colors rtl css is being loaded correctly. I think wp_admin_css_uri() needs to be fixed.

I've just fixed it, I attached the patch.

03/22/08 18:28:44 changed by mani_monaj

  • attachment colors-rtl-fix.patch added.

Colors RTL fix

03/22/08 18:33:31 changed by ryan

(In [7477]) Fix loading of colors RTL css. Props mani_monaj. see #6296

03/23/08 08:20:38 changed by mani_monaj

Could you please ignore wp-admin-rtl-edit3.patch and let me fix all issues and submit the final patch instead.

03/23/08 16:24:19 changed by ryan

see #6365 for some more RTL work

(follow-up: ↓ 10 ) 03/23/08 16:26:51 changed by ryan

Mani, take a look at #6365 and see if you can incorporate those changes.

(in reply to: ↑ 9 ) 03/23/08 16:53:33 changed by mani_monaj

Replying to ryan:

Mani, take a look at #6365 and see if you can incorporate those changes.

Sure, I'll take a look and try to merge the changes and prepare the final patch.

03/23/08 22:10:50 changed by mani_monaj

I manually merged our new patches with proposed changes in #6365 and attached the file. The only issue is the default font for RTL which has been leaved as Tahoma.

The RTL now looks good both on Firefox and IE7.

The remaining issues in RTL mode are:

1. The RSS/Text widgets in widget page; When opening the widget edit panel: In Firefox: The box becomes bigger than standard column size. In IE7: The box disappears!

2. In pages with lists and delete button (e.g. manage links), when hovering the delete button, the whole table moves some pixels to left

03/23/08 22:14:02 changed by mani_monaj

  • attachment wp-admin-rtl-edit3.patch added.

Improvements

03/24/08 02:51:52 changed by ryan

(In [7494]) RTL fixes from mani_monaj and RanYanivHartstein?. see #6296 #6365

03/24/08 07:17:21 changed by mani_monaj

@Ryan

The file theme-editor-rtl.css is not in changeset [7494]. Were there any problems with that file?

03/24/08 16:16:15 changed by ryan

(In [7501]) RTL fixes from mani_monaj and RanYanivHartstein??. see #6296 #6365

03/24/08 16:16:45 changed by ryan

I forgot to svn add theme-editor-rtl.css.

03/26/08 04:06:29 changed by thee17

  • status changed from reopened to closed.
  • resolution set to fixed.

03/27/08 20:29:46 changed by mani_monaj

  • status changed from closed to reopened.
  • resolution deleted.

As some original CSS files changed, I attached a new patch.

03/27/08 20:32:44 changed by mani_monaj

  • attachment wp-admin-rtl-edit4.patch added.

03/27/08 20:33:56 changed by ryan

(In [7552]) RTL fixes from mani_monaj. see #6296

03/27/08 20:36:27 changed by mani_monaj

We wrote a new rtl.css file for Kubrik, I attach this file too, it is completely different from the kubrik's original rtl.css file.

03/27/08 20:38:17 changed by mani_monaj

  • attachment kubrick-rtl.css added.

New Kubrik's rtl.css

03/27/08 20:42:50 changed by ryan

(In [7553]) Updated RTL for default theme from mani_monaj. see #6296

07/07/08 23:59:45 changed by ryan

  • status changed from reopened to closed.
  • resolution set to fixed.