Ticket #6386 (new defect (bug))

Opened 10 months ago

Last modified 10 months ago

Add Media dialogs too big on 800×600

Reported by: JeremyVisser Assigned to: andy
Priority: normal Milestone: 2.9
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch 2nd-opinion
Cc:

Description

If you change your screen resolution (like Spencer) or resize your browser (like I do often) to 800×600, you'll find that the Add Media dialogs are too big to fit.

Spencer has uploaded a screenshot of this here: http://www.vindictivebastard.com/images/image-uploadss.jpg

This comes from lines 170-173 of wp-admin/includes/media.php (rev 7517). If you change the height=500 in those lines to height=400, it works much better on 800×600.

I've attached a patch to change the heights to 400, but I'm not sure if it's the right way to go about it. A better solution would be to dynamically change the height with JavaScript? depending on what it detects your browser size as so it can accommodate automagically, but I don't understand any of this, so I can't really do it myself.

Attachments

media.php.diff (1.8 kB) - added by JeremyVisser on 03/26/08 04:44:42.

Change History

03/26/08 04:44:42 changed by JeremyVisser

  • attachment media.php.diff added.

03/26/08 04:45:11 changed by JeremyVisser

  • keywords set to has-patch 2nd-opinion.

03/26/08 05:56:45 changed by markjaquith

Benefit of browser window size detection: the modal window can be bigger for people with more real estate.