Ticket #6436 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

Shortcode attributes passing incorrectly

Reported by: stevish Assigned to: anonymous
Priority: highest omg bbq Milestone: 2.5
Component: General Version: 2.5
Severity: blocker Keywords: has-patch
Cc:

Description

In WP2.5 RC3, when adding attributes to a shortcode (such as [gallery columns="3"]) any quotation marks are passed as part of the variable. Therefore, in this example, the $columns variable would contain ”3″ instead of just 3. The same happens when using single quotes.

As far as I can tell, there is no way to use values with spaces, as everything after the space is ignored.

Attachments

6436.diff (332 bytes) - added by andy on 03/28/08 15:12:27.
filter shortcodes before wptexturize

Change History

03/28/08 15:09:57 changed by matt

  • priority changed from high to highest omg bbq.
  • severity changed from major to blocker.

03/28/08 15:12:27 changed by andy

  • attachment 6436.diff added.

filter shortcodes before wptexturize

03/28/08 15:12:50 changed by andy

  • keywords changed from RC3 to has-patch.

03/28/08 15:23:09 changed by matt

  • status changed from new to closed.
  • resolution set to fixed.

(In [7561]) Shortcode quotes were getting texturized, which can cause a bit of chaos. Fixes #6436.

03/29/08 20:59:06 changed by markjaquith

See #6444 -- this changeset causes really funky HTML. wpautop() mangles the heck out of gallery code, and likely will mangle other code.