Ticket #6539 (new defect)

Opened 2 months ago

Last modified 1 week ago

404 page does not appear when using static home page

Reported by: natecook Assigned to: ryan
Priority: normal Milestone: 2.5.2
Component: General Version: 2.5
Severity: normal Keywords: has-patch tested
Cc:

Description

If an installation is configured to have the home page set to a static page, with the "Front page" set but the "Posts page" unset, instead of the 404 template showing up when necessary, all pages are loaded and displayed.

Attachments

query-404.diff (0.6 kB) - added by natecook on 04/02/08 02:12:21.
Patch for fix
6539.patch (0.6 kB) - added by tenpura on 04/14/08 22:19:59.
Patch for 2.5 branch. Typecasts $reqpage to string to make the conditional work properly.
6539-modified.patch (0.6 kB) - added by azmeen on 04/26/08 19:18:46.
Patch 6539.patch didn't work for me. Merged the additional equal sign fix from the query-404.diff patch and tested working on WordPress 2.5.1.

Change History

04/02/08 02:12:21 changed by natecook

  • attachment query-404.diff added.

Patch for fix

04/02/08 22:41:19 changed by mtekk

  • keywords set to has-patch.

On r7591 I'm not seeing a error, if I enter garbage in the browser's navigation bar I get the 404 page as expected. Is there anything in particular that it should be doing?

04/03/08 18:21:24 changed by zoombody

I encountered this after upgrading from 2.3.3, and reproduced it on a clean 2.5 installation. The patch corrected the issue.

04/03/08 18:27:32 changed by zoombody

  • keywords changed from has-patch to has-patch tested.

04/03/08 18:30:14 changed by lloydbudd

  • milestone changed from 2.7 to 2.6.

04/04/08 16:18:51 changed by zoombody

  • milestone changed from 2.6 to 2.5.1.

I'm not sure whether it's cool for a non-developer to change milestones, but here goes.

04/06/08 18:42:32 changed by Nazgul

  • milestone changed from 2.5.1 to 2.6.

Usually we milestone for the current development version (or the next one if no patch is attached) and once it's comitted and deemed important enough it will be backported for a maintenance release.

04/06/08 23:23:05 changed by ryan

  • status changed from new to closed.
  • resolution set to fixed.

(In [7605]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.6

04/06/08 23:23:17 changed by ryan

(In [7606]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.5

04/06/08 23:23:55 changed by ryan

  • milestone changed from 2.6 to 2.5.1.

This is one looked safe for 2.5.1, committed.

04/08/08 01:05:45 changed by ryan

(In [7622]) Revert [7605]. It breaks setting posts page. see #6539

04/08/08 01:06:34 changed by ryan

(In [7623]) Revert [7606]. It breaks setting posts page. see #6539

04/08/08 01:08:32 changed by ryan

  • status changed from closed to reopened.
  • resolution deleted.

(follow-up: ↓ 14 ) 04/13/08 22:08:19 changed by tenpura

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

(in reply to: ↑ 13 ) 04/13/08 22:13:17 changed by tenpura

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

The patch typecasts $reqpage to string.

04/14/08 08:32:29 changed by tenpura

I updated 6539.patch. It does almost the same thing, but less code.

04/14/08 22:19:59 changed by tenpura

  • attachment 6539.patch added.

Patch for 2.5 branch. Typecasts $reqpage to string to make the conditional work properly.

04/26/08 19:18:46 changed by azmeen

  • attachment 6539-modified.patch added.

Patch 6539.patch didn't work for me. Merged the additional equal sign fix from the query-404.diff patch and tested working on WordPress 2.5.1.

05/07/08 17:01:30 changed by ryan

  • owner changed from anonymous to ryan.
  • status changed from reopened to new.

05/07/08 19:57:15 changed by ryan

(In [7905]) Fix page 404 when page_for_posts is empty. see #6539