Output broken in wp-admin/widgets.php

tom, could you provide more information into what you did to produce this bug? At the minimum it would be nice to know what widgets you used when you observed the bug.

Yes I will do later on, just wanted to ticket my observation because this is live in a customers project. Will upload more info later on, I guess this is easily patchable.

Okay, now I have got more Infos on the Issue:

This is "by Design". The %i% inside the ID is part of a codeblock that is used by some javascript as a pattern to create valid sourcecode later on. See line 62ff in widgets.js (?ver=20080319).

One solution which comes into my tired getting mind is to put the pattern-sourcecode inside a html comment (<!-- ... -->) and then use jQuery to create the elements later on. This would only slightly modify the code and would work quite the same. The only problem that comes into my mind is when a widget has got a HTML comment in it's own output.

I could verify this Idea by modifying the source:

wp-admin/includes/widgets.php line 91 ff

$widget_control_template = sprintf('%s<!-- %s -->%s', $sidebar_args['before_widget'], $widget_control_template, $sidebar_args['after_widget']);

wp-admin/js/widget.js: ~ line 63

		var oldLi = $(this).parents('li:first').find('ul.widget-control-info li');		
		var comment = oldLi.html();
		var pattern = comment.substr(5, comment.length - 8);
		var newLi = oldLi.clone();
		newLi.html(pattern);

I dunno wether this work with "multi widgets" because I know none sothat I could test it against it. But if I read the code right, it should work. With all the other widgets, this worked.

imo, this is asking for trouble... any widget with, not just a -->, but also a --, will break.

Replying to Denis-de-Bernardy:

imo, this is asking for trouble... any widget with, not just a -->, but also a --, will break.

can you explain to me why even -- will break it?

Milestone 2.5.2 deleted