Ticket #6602 (closed defect: fixed)

Opened 8 months ago

Last modified 4 months ago

kses Should Prevent Duplicate Attributes

Reported by: schiller Assigned to: anonymous
Priority: normal Milestone: 2.6.1
Component: General Version: 2.5.1
Severity: normal Keywords: has-patch 2nd-opinion
Cc: rubys@intertwingly.net

Description

The following is allowed, which would break a blog using strict XHTML:

<a href='foo' href='foo'>blah</a>

Attachments

bug6602.patch (3.0 kB) - added by schiller on 04/06/08 18:26:30.
Updated patch to take first attribute and ignore later duplicate attributes (per Sam Ruby's comment)

Change History

04/05/08 15:29:29 changed by schiller

  • cc set to rubys@intertwingly.net.

04/06/08 18:26:30 changed by schiller

  • attachment bug6602.patch added.

Updated patch to take first attribute and ignore later duplicate attributes (per Sam Ruby's comment)

04/10/08 01:28:52 changed by schiller

  • keywords changed from xhtml, kses to has-patch 2nd-opinion.

04/10/08 01:29:05 changed by schiller

  • milestone changed from 2.7 to 2.5.1.

06/13/08 17:36:48 changed by lloydbudd

  • version set to 2.5.1.
  • milestone changed from 2.5.2 to 2.6.

07/21/08 00:58:28 changed by azaozz

  • milestone changed from 2.9 to 2.7.

07/21/08 01:12:49 changed by azaozz

  • status changed from new to closed.
  • resolution set to fixed.

(In [8384]) Take first attribute and ignore later duplicate attributes. Fixes #6602 for trunk. Props schiller.

07/21/08 01:14:28 changed by azaozz

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.7 to 2.6.1.

Re-open for 2.6.1

07/21/08 01:15:50 changed by azaozz

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8385]) Take first attribute and ignore later duplicate attributes. Fixes #6602 for 2.6.1. Props schiller.